Script to get destination list for all screen configs#3100
Open
robbie-sundstrom wants to merge 2 commits into
Open
Script to get destination list for all screen configs#3100robbie-sundstrom wants to merge 2 commits into
robbie-sundstrom wants to merge 2 commits into
Conversation
deanshi
reviewed
Jun 10, 2026
deanshi
left a comment
deanshi
left a comment
Contributor
There was a problem hiding this comment.
I think looks good, but just a few clarifying questions from me!
| @@ -0,0 +1,212 @@ | |||
| # Script to get all of the destinations we could show on a given Screen | |||
| # Uses the local.json file to find each relevant screen's departure query params, | |||
Contributor
There was a problem hiding this comment.
Should this pull from the production S3 (or be given the option?) instead of using the local.json file? I'm just thinking if there's an off chance we accidentally use a non-prod local.json for the script.
Contributor
Author
There was a problem hiding this comment.
That's a good suggestion! I think I can make that the default and have it optionally pull from the local config
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana task: Enumerate route destinations for screen configs
See the Asana task or the CSV I accidentally added in my first commit for what this data looks like after running the script.
Could definitely be cleaned up a bit, but it's just a script that I don't see us running much more often.