fix: restore bootstrap overrides#745
Merged
Merged
Conversation
rwaskiewicz
force-pushed
the
rw/import-bootstrap
branch
from
7a885e4 to
6ee8c2b
Compare
In ad3b11b, we moved from `@import` to `@use` statements for most stylesheets. That change introduced a regression which led to certain default bootstrap styles to be used instead of the custom primary theme for screenplay. Migrating a single `@import` of Bootstrap to a `@use` caused the theme map we define in `Screenplay.scss` to not be taken into account when `bs-btn-*` styles are applied. As a result, the default Bootstrap Blue was used in a handful of UI components. This commit also includes a where the custom color of PA message "active" toggle was not being properly applied. This was caused by the previously global style not being applied to the toggle as a part of the migration.
rwaskiewicz
force-pushed
the
rw/import-bootstrap
branch
from
6ee8c2b to
79a4249
Compare
rwaskiewicz
commented
Jun 5, 2026
digitalcora
approved these changes
Jun 5, 2026
During the review of this commit, we realized that there was some duplication of the word 'form' when using `variables-screenplay-forms.scss`. As a part of refactoring the names, it was determined that we want to keep the variable names themselves, as they match Bootstrap variables names in order to override certain defaults. However, we can remove the file entirely, as the values in this file are represented in `variables.scss`. Move the contents of `variables-screenplay-forms.scss` to the theme map to override Bootstrap defaults, and directly replace its usages with their `variables.scss` compliements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Asana task: N/A
Description
In ad3b11b, we moved from
@importto@usestatements for moststylesheets. That change introduced a regression which led to certain
default bootstrap styles to be used instead of the custom primary theme
for screenplay. Migrating a single
@importof Bootstrap to a@usecaused the theme map we define in
Screenplay.scssto not be taken intoaccount when
bs-btn-*styles are applied. As a result, the defaultBootstrap Blue was used in a handful of UI components.
This commit also includes a where the custom color of PA message
"active" toggle was not being properly applied. This was caused by the
previously global style not being applied to the toggle as a part of the
migration.
Before - Action Buttons
After - Action Buttons
Before - Active Toggle
After - Active Toggle
