fix(alert): More permissive URL regex#3261
Merged
Merged
Conversation
lvachon1
approved these changes
Jun 12, 2026
lvachon1
left a comment
lvachon1
left a comment
Contributor
There was a problem hiding this comment.
I didn't realize character ranges in regex expressions (eg, a-z or 0-9) can be between any two ascii code points, neat!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Asana Ticket:⚠️ Fix alerts with URLs with weird chars
Implementation
Adds a bunch of characters to the url regex to be allowed.
Screenshots
Before: link shown is split
After: link is together
How to test
Find some live alerts in local that are broken (need to be pointed to
api-dev) and verify they're no longer broken.http://localhost:4001/schedules/CR-Providence/timetable
Providence currently has one