Skip to content

SF2.0[fix]: Skipped Stops disappear when the schedule drifts into the past, even if the vehicle is still upstream #3230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lvachon1 wants to merge 6 commits into
base: main
Choose a base branch
from
+65 −1
Open

SF2.0[fix]: Skipped Stops disappear when the schedule drifts into the past, even if the vehicle is still upstream #3230

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2fc84c9
Removed time filtering from predicted schedules on trip details so th…
lvachon1 Jun 4, 2026
c597290
Skipping a test that doesn't seem relevant anymore?
lvachon1 Jun 4, 2026
7db5af0
Unskipped test, refactored fix to be a bit more precise.
lvachon1 Jun 4, 2026
010d2b1
Test attempt
lvachon1 Jun 6, 2026
c4ef0e6
Working version of test for up/downstream skipped stops
lvachon1 Jun 8, 2026
1a176d1
Lint
lvachon1 Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/dotcom/upcoming_departures/processor.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,16 @@ defmodule Dotcom.UpcomingDepartures.Processor do
!prediction_departure_time && !schedule_departure_time
end

defp past_schedule_keep_skipped?(
%PredictedSchedule{schedule: %Schedule{departure_time: time}, prediction: prediction},
now
)
when time != nil do
is_nil(prediction) and DateTime.before?(time, now)
end

defp past_schedule_keep_skipped?(_, _), do: false

defp past_schedule?(
%PredictedSchedule{schedule: %Schedule{departure_time: time}, prediction: prediction},
now
Expand Down Expand Up @@ -296,7 +306,7 @@ defmodule Dotcom.UpcomingDepartures.Processor do

predicted_schedules =
PredictedSchedule.group(predictions, schedules)
|> Enum.reject(&past_schedule?(&1, now))
|> Enum.reject(&past_schedule_keep_skipped?(&1, now))

vehicle =
predicted_schedules
Expand Down
Loading