Skip to content

fix helm template - #819

Open
r-de-waard wants to merge 1 commit into
mbentley:masterfrom
r-de-waard:helm-fix
Open

fix helm template#819
r-de-waard wants to merge 1 commit into
mbentley:masterfrom
r-de-waard:helm-fix

Conversation

@r-de-waard

Copy link
Copy Markdown

No description provided.

@mbentley

mbentley commented Sep 8, 2026

Copy link
Copy Markdown
Owner

I haven't had a chance to look at this in depth but this would need to bump the bugfix version to 1.5.3 and update the README to explain the change/fix.

@r-de-waard

Copy link
Copy Markdown
Author

Yes, the chart needs an update. The values in the template didn't match the key/pair in the values file, so it failed.
The Helm chart currently only has an ingress and lacks a section for the Gateway API. Let me know if you want me to add that part.

@mbentley

mbentley commented Sep 9, 2026

Copy link
Copy Markdown
Owner

Great call out. I am going to merge this PR as is once the version bump gets added and README updated and I would certainly appreciate the help in adding GatewayAPI support in another PR. Here are my thoughts:

Add Gateway API support as a new feature that can users can opt in to using instead of directly replacing Ingress. My suggestion would be something like:

  • New templates for Gateway API support (gateway.yaml, httproute.yaml, etc) behind a flag like .Values.gatewayApi.enabled defaulting to false so the current behavior is maintained and opt-in.
  • It would also be great to add a Helm capabilities check - something like {{- if .Values.gatewayApi.enabled }} + {{- if $.Capabilities.APIVersions.Has "gateway.networking.k8s.io/v1" }}, so even if it's configured to be true on a cluster without the CRDs installed, it fails early with a clear message.

If you have any other ideas, happy to entertain those as well.

@mbentley mbentley left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump the bugfix version to 1.5.3 and update the README to explain the change/fix and this will be good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants