PP-324 [#2203] refactor paragraph modifiers#2430
Merged
jiromaykin merged 1 commit intoMay 11, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## nlds-para-heading-implementation #2430 +/- ##
===================================================================
Coverage ? 93.97%
===================================================================
Files ? 1221
Lines ? 48676
Branches ? 0
===================================================================
Hits ? 45742
Misses ? 2934
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a759269 to
faa8cf1
Compare
a1dd0e5 to
afb0b8e
Compare
5699fd3 to
5dc85e8
Compare
faa8cf1 to
943e590
Compare
3ea4a25 to
addba1b
Compare
943e590 to
27767f5
Compare
6a38d5f to
a7f2460
Compare
4f86ad5 to
566b206
Compare
stefrado
requested changes
Apr 28, 2026
566b206 to
e918209
Compare
3eac32b to
791c636
Compare
822de55 to
01e42d7
Compare
pi-sigma
requested changes
May 6, 2026
e55066f to
005d10b
Compare
791c636 to
af5f89f
Compare
005d10b to
8731db2
Compare
4351b5a to
8bbb7c3
Compare
stefrado
approved these changes
May 8, 2026
pi-sigma
approved these changes
May 11, 2026
af5f89f to
9a205ef
Compare
d8a21b6 to
204ad49
Compare
b2bd07e to
1dbf851
Compare
e4d44ed
into
nlds-para-heading-implementation
11 of 12 checks passed
jiromaykin
added a commit
that referenced
this pull request
May 11, 2026
jiromaykin
added a commit
that referenced
this pull request
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor small/muted modifiers or replace them if they are part of NLDS components.
When paragraphs do not really function as actual text content, but function more like 'labels' they can be replaced with spans.
margin-bottom/topetc should be replaced withmargin-block-start/endetc. so to give the opportunity to change them with separate future design tokens.At least every utrecht-paragraph reference should be completely removed.
Advice from NLDS (not a hard requirment)
https://nldesignsystem.nl/richtlijnen/stijl/typografie/lettergrootte/
https://nldesignsystem.nl/richtlijnen/stijl/typografie/uitlijning/
Some changed components:
Most templates do not have any style changes, and paragraphs should look the same before/after chaging them into NLDS web components.
Keeping the Case Cards in OIP design for now, so they will not look like the NLDS Case Cards and are keeping their smaller size font: https://github.com/orgs/nl-design-system/discussions/204
File list on Zaak detail, needs to remain in Groningen-tested design
Issue References
closes PP-324
Note this PR needs design-tokens from another PR: maykinmedia/open-inwoner-design-tokens#43
And note that there have been previous PR's that work together with all/more paragraph changes:
#2394
maykinmedia/open-inwoner-design-tokens#41
#2429
#2394
maykinmedia/open-inwoner-design-tokens#42
Checklist