Skip to content

PP-324 [#2203] refactor paragraph modifiers#2430

Merged
jiromaykin merged 1 commit into
nlds-para-heading-implementationfrom
feature/2427-refactor-paragraph-modifiers
May 11, 2026
Merged

PP-324 [#2203] refactor paragraph modifiers#2430
jiromaykin merged 1 commit into
nlds-para-heading-implementationfrom
feature/2427-refactor-paragraph-modifiers

Conversation

@jiromaykin
Copy link
Copy Markdown
Contributor

@jiromaykin jiromaykin commented Apr 16, 2026

Summary

Refactor small/muted modifiers or replace them if they are part of NLDS components.
When paragraphs do not really function as actual text content, but function more like 'labels' they can be replaced with spans.
margin-bottom/top etc should be replaced with margin-block-start/end etc. so to give the opportunity to change them with separate future design tokens.
At least every utrecht-paragraph reference should be completely removed.

Advice from NLDS (not a hard requirment)

Some changed components:

Most templates do not have any style changes, and paragraphs should look the same before/after chaging them into NLDS web components.

Keeping the Case Cards in OIP design for now, so they will not look like the NLDS Case Cards and are keeping their smaller size font: https://github.com/orgs/nl-design-system/discussions/204

File list on Zaak detail, needs to remain in Groningen-tested design

Screenshot 2026-04-21 at 12 09 19 Screenshot 2026-04-21 at 16 19 28 Screenshot 2026-04-21 at 16 23 56

Issue References

closes PP-324
Note this PR needs design-tokens from another PR: maykinmedia/open-inwoner-design-tokens#43
And note that there have been previous PR's that work together with all/more paragraph changes:

#2394
maykinmedia/open-inwoner-design-tokens#41
#2429
#2394
maykinmedia/open-inwoner-design-tokens#42

Checklist

  • CHANGELOG.rst updated
  • Codecov report reviewed for untested lines

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (nlds-para-heading-implementation@9a205ef). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/open_inwoner/cms/cases/tests/test_htmx.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##             nlds-para-heading-implementation    #2430   +/-   ##
===================================================================
  Coverage                                    ?   93.97%           
===================================================================
  Files                                       ?     1221           
  Lines                                       ?    48676           
  Branches                                    ?        0           
===================================================================
  Hits                                        ?    45742           
  Misses                                      ?     2934           
  Partials                                    ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jiromaykin jiromaykin force-pushed the nlds-para-heading-implementation branch from a759269 to faa8cf1 Compare April 20, 2026 07:47
@jiromaykin jiromaykin force-pushed the feature/2427-refactor-paragraph-modifiers branch 2 times, most recently from a1dd0e5 to afb0b8e Compare April 20, 2026 08:30
@jiromaykin jiromaykin changed the title [#2427] refactor paragraph modifiers PP-324 [#2427] refactor paragraph modifiers Apr 21, 2026
@jiromaykin jiromaykin force-pushed the feature/2427-refactor-paragraph-modifiers branch from 5699fd3 to 5dc85e8 Compare April 21, 2026 13:08
@jiromaykin jiromaykin force-pushed the nlds-para-heading-implementation branch from faa8cf1 to 943e590 Compare April 21, 2026 15:37
@jiromaykin jiromaykin force-pushed the feature/2427-refactor-paragraph-modifiers branch 5 times, most recently from 3ea4a25 to addba1b Compare April 28, 2026 08:45
@jiromaykin jiromaykin force-pushed the nlds-para-heading-implementation branch from 943e590 to 27767f5 Compare April 28, 2026 08:51
@jiromaykin jiromaykin force-pushed the feature/2427-refactor-paragraph-modifiers branch 2 times, most recently from 6a38d5f to a7f2460 Compare April 28, 2026 09:05
@jiromaykin jiromaykin marked this pull request as ready for review April 28, 2026 09:21
@jiromaykin jiromaykin force-pushed the feature/2427-refactor-paragraph-modifiers branch from 4f86ad5 to 566b206 Compare April 28, 2026 09:59
Comment thread src/open_inwoner/js/components/siteimprove/tracking.js
Comment thread src/open_inwoner/react/components/Paragraph/Paragraph.scss
Comment thread src/open_inwoner/scss/components/Contactmomenten/Contactmomenten.scss Outdated
Comment thread src/open_inwoner/scss/components/Plan/Plan.scss Outdated
Comment thread src/open_inwoner/scss/components/_index.scss
Comment thread src/open_inwoner/templates/digid_eherkenning/mock/base.html
Comment thread src/open_inwoner/templates/pages/partials/question.html
Comment thread src/open_inwoner/templates/pages/plans/template-choice.html Outdated
Comment thread CHANGELOG.rst Outdated
@jiromaykin jiromaykin force-pushed the feature/2427-refactor-paragraph-modifiers branch from 566b206 to e918209 Compare April 30, 2026 12:08
@jiromaykin jiromaykin force-pushed the nlds-para-heading-implementation branch from 3eac32b to 791c636 Compare May 4, 2026 09:39
@jiromaykin jiromaykin force-pushed the feature/2427-refactor-paragraph-modifiers branch from 822de55 to 01e42d7 Compare May 4, 2026 09:55
Comment thread src/open_inwoner/components/templates/components/Notification/Notification.html Outdated
Comment thread src/open_inwoner/components/templates/components/Product/finder.html Outdated
Comment thread src/open_inwoner/react/components/HomePluginCard/HomePluginCard.scss Outdated
Comment thread src/open_inwoner/scss/components/Contactmomenten/Contactmomenten.scss Outdated
Comment thread src/open_inwoner/scss/components/Dashboard/Dashboard.scss Outdated
@jiromaykin jiromaykin force-pushed the feature/2427-refactor-paragraph-modifiers branch from e55066f to 005d10b Compare May 6, 2026 15:25
@jiromaykin jiromaykin force-pushed the nlds-para-heading-implementation branch from 791c636 to af5f89f Compare May 6, 2026 16:47
@jiromaykin jiromaykin force-pushed the feature/2427-refactor-paragraph-modifiers branch from 005d10b to 8731db2 Compare May 6, 2026 17:20
@jiromaykin jiromaykin force-pushed the feature/2427-refactor-paragraph-modifiers branch from 4351b5a to 8bbb7c3 Compare May 6, 2026 18:39
@jiromaykin jiromaykin requested review from pi-sigma and stefrado May 7, 2026 09:40
@jiromaykin jiromaykin force-pushed the nlds-para-heading-implementation branch from af5f89f to 9a205ef Compare May 11, 2026 08:38
@jiromaykin jiromaykin force-pushed the feature/2427-refactor-paragraph-modifiers branch 2 times, most recently from d8a21b6 to 204ad49 Compare May 11, 2026 10:30
@jiromaykin jiromaykin force-pushed the feature/2427-refactor-paragraph-modifiers branch from b2bd07e to 1dbf851 Compare May 11, 2026 11:22
@jiromaykin jiromaykin merged commit e4d44ed into nlds-para-heading-implementation May 11, 2026
11 of 12 checks passed
@jiromaykin jiromaykin deleted the feature/2427-refactor-paragraph-modifiers branch May 11, 2026 11:38
@jiromaykin jiromaykin changed the title PP-324 [#2427] refactor paragraph modifiers PP-324 [#2203] refactor paragraph modifiers May 11, 2026
jiromaykin added a commit that referenced this pull request May 11, 2026
jiromaykin added a commit that referenced this pull request May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PP-324 [#2203] Convert and/or refactor OIP paragraph modifiers to NLDS

4 participants