:sprarkles: feat: implement editor locking to reduce the chance of ra…#130
:sprarkles: feat: implement editor locking to reduce the chance of ra…#130svenvandescheur wants to merge 1 commit intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 76.10% 75.92% -0.18%
==========================================
Files 77 77
Lines 2385 2388 +3
Branches 149 149
==========================================
- Hits 1815 1813 -2
- Misses 541 546 +5
Partials 29 29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielmursa-dev
left a comment
There was a problem hiding this comment.
Tested 👍. For now, the HttpResponse with the URL is fine, but we could improve it in some other way in the future, with other response
|
Yes, the response may be a little better shaped/specified
Yes, the response may be a little better shaped/specified. I don want some more time to test this properly as I'm seeing weiredness with expired tokens. So lets not merge yet. |
…ce condition
Fixes #
Changes
This keeps track of opened Window for the editor in state, which is checked in the poll cycle. Saving the file is not allowed when an active editor is found. This is not full-proof but reduces the risks of race conditions.