Skip to content

:sprarkles: feat: implement editor locking to reduce the chance of ra…#130

Closed
svenvandescheur wants to merge 1 commit intomainfrom
feat/reduce-risk-race-condition
Closed

:sprarkles: feat: implement editor locking to reduce the chance of ra…#130
svenvandescheur wants to merge 1 commit intomainfrom
feat/reduce-risk-race-condition

Conversation

@svenvandescheur
Copy link
Copy Markdown
Collaborator

…ce condition

Fixes #

Changes

This keeps track of opened Window for the editor in state, which is checked in the poll cycle. Saving the file is not allowed when an active editor is found. This is not full-proof but reduces the risks of race conditions.

@danielmursa-dev danielmursa-dev self-requested a review April 20, 2026 14:20
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.92%. Comparing base (357133b) to head (41eafb7).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../opendms/doc_edit/backends/ms_graph_api/backend.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   76.10%   75.92%   -0.18%     
==========================================
  Files          77       77              
  Lines        2385     2388       +3     
  Branches      149      149              
==========================================
- Hits         1815     1813       -2     
- Misses        541      546       +5     
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@danielmursa-dev danielmursa-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 👍. For now, the HttpResponse with the URL is fine, but we could improve it in some other way in the future, with other response

@svenvandescheur
Copy link
Copy Markdown
Collaborator Author

Yes, the response may be a little better shaped/specified

Tested 👍. For now, the HttpResponse with the URL is fine, but we could improve it in some other way in the future, with other response

Yes, the response may be a little better shaped/specified. I don want some more time to test this properly as I'm seeing weiredness with expired tokens. So lets not merge yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants