Skip to content

refactor: replace \fromSecret\ bool with typed \SecretType\ enum on \SecretVar\``#4602

Closed
BearTS wants to merge 1 commit into
06-22-refactor_change_ref_-_secretreffrom
06-22-feat_add_secret_type_instead_of_from_secret
Closed

refactor: replace \fromSecret\ bool with typed \SecretType\ enum on \SecretVar\``#4602
BearTS wants to merge 1 commit into
06-22-refactor_change_ref_-_secretreffrom
06-22-feat_add_secret_type_instead_of_from_secret

Conversation

@BearTS

@BearTS BearTS commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Briefly explain the purpose of this PR and the problem it solves.

Changes

  • What was changed and why
  • Any notable design decisions or trade-offs

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

Describe the steps to validate this change. Include commands and expected outcomes.

# Core/Transports
go version
go test ./...

# UI
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build

If adding new configs or environment variables, document them here.

Screenshots/Recordings

If UI changes, add before/after screenshots or short clips.

Breaking changes

  • Yes
  • No

If yes, describe impact and migration instructions.

Related issues

Link related issues and discussions. Example: Closes #123

Security considerations

Note any security implications (auth, secrets, PII, sandboxing, etc.).

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 87bbe0a4-86f6-4e6e-8c57-4f8091d0a4c9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 06-22-feat_add_secret_type_instead_of_from_secret

Comment @coderabbitai help to get the list of available commands and usage tips.

@BearTS BearTS changed the title feat: add secret type instead of from secret refactor: replace \fromSecret\ bool with typed \SecretType\ enum on \SecretVar\`` Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant