removing old pii redactors ui code + presidio icon

[Madhuvod]

Summary

Briefly explain the purpose of this PR and the problem it solves.

Changes

• What was changed and why
• Any notable design decisions or trade-offs

Type of change

• Bug fix
• Feature
• Refactor
• Documentation
• Chore/CI

Affected areas

• Core (Go)
• Transports (HTTP)
• Providers/Integrations
• Plugins
• UI (React)
• Docs

How to test

Describe the steps to validate this change. Include commands and expected outcomes.

# Core/Transports
go version
go test ./...

# UI
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build

If adding new configs or environment variables, document them here.

Screenshots/Recordings

If UI changes, add before/after screenshots or short clips.

Breaking changes

• Yes
• No

If yes, describe impact and migration instructions.

Related issues

Link related issues and discussions. Example: Closes #123

Security considerations

Note any security implications (auth, secrets, PII, sandboxing, etc.).

Checklist

• I read docs/contributing/README.md and followed the guidelines
• I added/updated tests where appropriate
• I updated documentation where needed
• I verified builds succeed (Go and UI)
• I verified the CI pipeline passes locally if applicable

Summary by CodeRabbit

• Chores
  • Removed the PII Redactor feature from the workspace, including its pages and routes.
  • Removed the enterprise fallback UI that displayed upsell/contact prompts for PII redaction.
  • Updated access control resources: removed the PIIRedactor entry and added RBAC, Governance, and RoutingRules.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

This PR removes the PII Redactor feature: workspace routes, pages, and fallback enterprise PII components were deleted, and the RbacResource enum was updated to remove PIIRedactor and add RBAC, Governance, and RoutingRules.

Changes

PII Redactor Feature Removal

Layer / File(s)	Summary
RBAC resource contracts ui/app/_fallbacks/enterprise/lib/contexts/rbacContext.tsx	RbacResource enum updated: PIIRedactor removed; added RBAC, Governance, and RoutingRules.
Workspace routes, pages and fallback PII components removed ui/app/workspace/pii-redactor/*, ui/app/_fallbacks/enterprise/components/pii-redactor/*	All workspace routes and pages under /workspace/pii-redactor and fallback enterprise components PiiRedactorProviderView and PiiRedactorRulesView were deleted.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• maximhq/bifrost#3715: Updates RbacResource to remove PIIRedactor and add RoutingRules, relevant to route gating with RoutingRules.

Suggested reviewers

• danpiths
• akshaydeo

Poem

🐰 I hopped through files with gentle cheer,
Redacted pages disappear,
RBAC sprouted names both bright and neat,
A carrot clap for tidy feat,
Nose twitch — the tree of code stands clear.

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is entirely a template with no actual content filled in. All sections are empty placeholders, including Summary, Changes, Type of change, and related critical details.	Fill in the PR description template with concrete details: summary of purpose, specific changes made (component removals, enum updates), type of change, affected areas, test steps, and related issue links.
Linked Issues check	⚠️ Warning	The linked issue #123 is about Files API Support for providers; the PR changes are about removing PII redactor UI code. These are completely unrelated objectives.	Link the correct issue(s) related to PII redactor removal, or clarify if this PR should remove the #123 link and reference appropriate tracking issues.
Out of Scope Changes check	❓ Inconclusive	Cannot fully assess scope alignment because the PR description lacks details and the linked issue is unrelated to the actual changes made (PII redactor removal).	Provide clear PR description with scope definition and link relevant issues to establish proper context for evaluating whether all changes are in-scope.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'removing old pii redactors ui code + presidio icon' directly summarizes the main change: removal of deprecated PII redactor UI components and related code.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 06-08-removing_old_pii_redactors_ui_code_presidio_icon

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Madhuvod]

• docs for redaction #4565
• feat(logging): redact trace content before connector export #4417
• feat(logging): add transient redaction data field and context key for guardrails #4169
• removing old pii redactors ui code + presidio icon #4133 👈 (View in Graphite)
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Confidence Score: 5/5

Pure deletion of dead UI code — no logic is altered, no remaining references exist, and the route tree is fully removed.

All nine deleted files are self-contained; a repository-wide search confirms no imports, route links, or navigation entries still reference them. The only live-file change is removing one enum value from rbacContext.tsx, which compiles cleanly with no consumers left.

No files require special attention.

Important Files Changed

Filename	Overview
ui/app/_fallbacks/enterprise/lib/contexts/rbacContext.tsx	Removes PIIRedactor from the RbacResource enum; a grep confirms no remaining references to this value exist anywhere in the UI.
ui/app/_fallbacks/enterprise/components/pii-redactor/piiRedactorProviderView.tsx	Deleted fallback enterprise component; no remaining imports or references.
ui/app/_fallbacks/enterprise/components/pii-redactor/piiRedactorRulesView.tsx	Deleted fallback enterprise component; no remaining imports or references.
ui/app/workspace/pii-redactor/layout.tsx	Deleted root route layout that guarded PIIRedactor access; access-control logic removed with the route.

_{Reviews (11): Last reviewed commit: "removing old pii redactors ui code + pre..." | Re-trigger Greptile}

[CLAassistant]

All committers have signed the CLA.

[akshaydeo]

@Madhuvod do we still need this PR?

[Madhuvod]

@Madhuvod do we still need this PR?

@akshaydeo yes we do, this is the bottom pr in the oss stack i have for the whole reversible redaction support. will sync and get all of this merged asap. currently working on the final bit - extending the reversible redaction to connectors (otel etc)