moved the part where the user agent is set to constructRequest function#2
Open
imolein wants to merge 1 commit intomatterbridge:workfrom
Open
moved the part where the user agent is set to constructRequest function#2imolein wants to merge 1 commit intomatterbridge:workfrom
imolein wants to merge 1 commit intomatterbridge:workfrom
Conversation
imolein
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not a Go programmer and I don't have the environment to test this, but from my understanding of the code and the fact that I see on my zulip server that matterbridge is only setting the user-agent on subscription requests, I moved the user-agent part into the
constructRequestfunction. Then the user-agent should be correctly set on every request to zulip.I hope my assumption is correct :)