Skip to content

Fix compaction, hybrid pairing, stream ownership and SDK builds - #14

Merged
matte1782 merged 2 commits into
mainfrom
fix/remaining-closeout
Oct 20, 2026
Merged

matte1782 merged 2 commits into
mainfrom
fix/remaining-closeout

Conversation

@matte1782

@matte1782 matte1782 commented Oct 19, 2026 •

Copy link
Copy Markdown
Owner

Saved TypeScript clients could report incorrect dimensions/counts, binary compaction could panic, hybrid search could fuse different document IDs, and streaming iterators borrowed mutable source state. Clean package builds also omitted required exports/runtime files and had broken CommonJS entry points/types.

This follow-up to #13 fixes compaction for binary, SQ8 and BQ storage; remaps WASM metadata and hybrid document pairings; corrects linear distance ranking; and makes streaming own a stable EVWB snapshot. It also fixes loaded wrapper state, Node initialization, package exports/files, conditional CommonJS declarations, and reproducible TypeScript builds. CI now tests the actual SDK and installed tarballs, including browser bundling and strict ESM/CommonJS type resolution.

Benchmark workflows publish reports to Actions summaries and artifacts, removing failed PR comment writes. Explicit Bash pipefail preserves benchmark failures through report capture, and incomplete checks receive an honest failure summary.

save_stream() now eagerly owns the complete serialized snapshot plus emitted chunks. Its chunks reassemble to EVWB (identical to toBytes()), while retaining the 64-byte minimum. The API documentation explains this memory/format change and the runtime-only sparse pairing contract.

Validation: 3,490 native tests pass (32 existing ignored), 10 WASM persistence tests, 16 runtime regressions, 33 Jest unit tests, 11 IndexedDB shim tests, package/demo persistence glue, 200,000 mutation cases, and strict native/WASM Clippy. Installed ESM/CommonJS consumers pass on Node 16.20.2 and 22.21.0; TypeScript Node16 resolution with skipLibCheck:false has no diagnostics. WASM is 685,769 bytes; six cold 100k/128d loads are 139–161 ms.

Evidence: docs/reviews/2026-10-20_closeout_validation.md and docs/benchmarks/2026-10-20_closeout.json. Independent hostile review approved GitHub publication; merge remains gated on hosted CI and real mobile-device results.

@matte1782
matte1782 merged commit 59146c7 into main Oct 20, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant