Document m.get_login_token capability - #1908
Merged
anoadragon453 merged 3 commits intoJul 19, 2024
Merged
Conversation
Fixes: matrix-org#1547 Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Johennes
commented
Jul 12, 2024
| to generate single-use, time-limited tokens to log unauthenticated clients | ||
| into their account. | ||
|
|
||
| When not listed, clients SHOULD assume the user is unable to generate tokens. |
Contributor
Author
There was a problem hiding this comment.
MSC3882 doesn't appear to specify how to behave in this case. The only implementations I found are in matrix-js-sdk and matrix-react-sdk and if I'm reading them correctly, they default to enabled == false if the capability is missing.
SHOULD seemed sufficient here because if a client would still call the endpoint, it would simply receive an error response which it must be prepared to handle in any case.
Johennes
marked this pull request as ready for review
July 12, 2024 13:36
anoadragon453
approved these changes
Jul 19, 2024
anoadragon453
left a comment
anoadragon453
left a comment
Member
There was a problem hiding this comment.
This LGTM, and was a glaring omission. Thanks for adding it!
This was referenced Sep 5, 2024
44 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1547
Pull Request Checklist
Preview: https://pr1908--matrix-spec-previews.netlify.app