Threads: The base - #1254
Threads: The base#1254
Conversation
Other threading MSCs to follow
erikjohnston
left a comment
erikjohnston
left a comment
There was a problem hiding this comment.
Words look good. I defer to @clokep about whether this matches reality (though AIUI it does)
clokep
left a comment
clokep
left a comment
There was a problem hiding this comment.
Examples look reasonable to me, just a couple of minor points.
| `latest_event` is the most recent event (topologically to the server) in the thread sent by an | ||
| un-[ignored user](#ignoring-users). |
There was a problem hiding this comment.
I'm not sure it needs to be called out, but the bundled latest_event should be serialized using the same format as the event itself.
There was a problem hiding this comment.
This is done via the spec and examples implicitly: the other weird formats aren't in the spec anymore, as that's a legacy implementation detail in some clients and servers.
There was a problem hiding this comment.
Oh, I hadn't realized those were no longer in the spec. Please ignore me then!
|
|
||
| As a worked example, the following represents a thread and how it'd be formed: | ||
|
|
||
| ```json |
There was a problem hiding this comment.
Should we use json5 or jsonc to highlight syntax here and in other code examples?
There was a problem hiding this comment.
json because hugo does a better job than github, annoyingly.
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
* Spec MSC3440: Threading (just the base) Other threading MSCs to follow * Spec MSC3856: Threads list API * Spec MSC3715: Add`dir` to `/relations` * changelog * Apply suggestions from code review Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Update changelogs/client_server/newsfragments/1254.feature Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
4 participants
Specifies matrix-org/matrix-spec-proposals#3440 (minus filtering requirements due to MSC3856)
Specifies matrix-org/matrix-spec-proposals#3856
Specifies matrix-org/matrix-spec-proposals#3715
This is reviewable commit-by-commit, for each of the MSCs listed above.
The remainder of the threads work (notifications, read receipts) is handled by #1255.
Requires matrix-org/matrix-spec-proposals#3899 for clarifications.
Preview: https://pr1254--matrix-spec-previews.netlify.app