MSC3267: Reference relations by bwindels · Pull Request #3267 · matrix-org/matrix-spec-proposals

bwindels · 2021-07-05T15:13:44Z

Implementation: The key verification framework

uhoreg · 2021-07-05T18:49:58Z

Tagged as needs-implementation even though the verification use-case in implemented, since the non-verification use-case is not yet implemented

jplatte · 2022-05-17T12:21:40Z

Given that m.references has already found its way into the spec for encrypted events and threads have gone a different direction if I'm not getting things mixed up, should this MSC be closed?

turt2live · 2022-05-17T18:40:29Z

(please use threads to receive in-depth/any replies)

The way m.reference has made it into the spec currently doesn't require this MSC, but it looks super strange indeed. We should fast track this to FCP, I guess.

turt2live · 2022-05-20T01:45:58Z

going to use the key verification framework as an implementation proof for this - https://spec.matrix.org/v1.2/client-server-api/#key-verification-framework

turt2live · 2022-05-20T01:53:35Z

@bwindels apologies, I've taken this over in an effort to get it through (finally).

clokep · 2022-05-27T11:47:39Z

+A `rel_type` of `m.reference` is defined as a generic way to associate an
+event with another event. As a bundle, `m.reference` relations appear as
+an object with a single `chunk` field. The `chunk` is an array of objects
+with a single `event_id` field for all the child events which `m.reference`
+the parent.


It is just the first "page" of results, if there's a next_token, that can be given to /relations to get the rest.

Perhaps we can just remove the word "all" in this sentence to eliminate any subtle confusion.

anoadragon453 · 2022-07-05T16:33:59Z

+for events to make a reference to another event.
+
+A `rel_type` of `m.reference` is defined as a generic way to associate an
+event with another event. As a bundle, `m.reference` relations appear as


It would be useful to link to MSC2675 here, which defines bundling related events.

Actually, we can probably just remove the sentences about server-side aggregation given the information is repeated below under the "Server aggregation" header?

anoadragon453 · 2022-07-05T16:54:13Z

+A `rel_type` of `m.reference` is defined as a generic way to associate an
+event with another event. As a bundle, `m.reference` relations appear as
+an object with a single `chunk` field. The `chunk` is an array of objects
+with a single `event_id` field for all the child events which `m.reference`
+the parent.


Perhaps we can just remove the word "all" in this sentence to eliminate any subtle confusion.

richvdh · 2022-07-12T13:40:34Z

+
+## Server aggregation
+
+[MSC2674](https://github.com/matrix-org/matrix-doc/pull/2674) states


I think this is MSC2675 now?

mscbot · 2022-07-12T13:54:18Z

🔔 This is now entering its final comment period, as per the review above. 🔔

mscbot · 2022-07-17T13:54:28Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

* initial draft of reference relations msc * change MSC number * Apply formatting * Convert to point at present rather than ideal * Clarify that multiple relations is a thing we don't have and won't fix here * Fix wording to match reality, again * fix a typo Co-authored-by: Travis Ralston <travisr@matrix.org> Co-authored-by: Andrew Morgan <andrewm@element.io>

MSC: matrix-org/matrix-spec-proposals#3267

turt2live · 2022-08-09T21:47:26Z

Spec PR: matrix-org/matrix-spec#1206

* Spec reference relationships MSC: matrix-org/matrix-spec-proposals#3267 * Apply suggestions from code review Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Edits per code review Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

turt2live · 2022-10-18T17:51:10Z

Merged 🎉

* Spec reference relationships MSC: matrix-org/matrix-spec-proposals#3267 * Apply suggestions from code review Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Edits per code review Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>

initial draft of reference relations msc

b36c24f

bwindels changed the title ~~MSCXXXX: Reference relations~~ MSC 3267: Reference relations Jul 5, 2021

change MSC number

ab551e8

bwindels mentioned this pull request Jul 5, 2021

MSC2241: Key verification in DMs #2241

Merged

deepbluev7 reviewed Jul 5, 2021

View reviewed changes

Comment thread proposals/3267-reference-relations.md Outdated

uhoreg added kind:feature MSC for not-core and not-maintenance stuff needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. proposal A matrix spec change proposal. Process state. proposal-in-review labels Jul 5, 2021

jryans changed the title ~~MSC 3267: Reference relations~~ MSC3267: Reference relations Jul 7, 2021

turt2live force-pushed the old_master branch from e895827 to dca99ee Compare August 30, 2021 22:34

This was referenced Oct 14, 2021

MSC3440: Threading via m.thread relation #3440

Merged

MSC2836: Twitter-style Threading #2836

Open

turt2live added A-Client Server Client-Server API and removed proposal-in-review labels Nov 24, 2021

lukasdenk mentioned this pull request Jan 3, 2022

type property missing for m.reference relations matrix-org/synapse#7941

Closed

clokep reviewed Jan 4, 2022

View reviewed changes

Comment thread proposals/3267-reference-relations.md Outdated

zecakeh mentioned this pull request Mar 28, 2022

MSC3381: Polls ruma/ruma#1031

Closed

turt2live mentioned this pull request Apr 5, 2022

MSC3672: Sharing ephemeral streams of location data #3672

Open

grinapo reviewed Apr 14, 2022

View reviewed changes

Comment thread proposals/3267-reference-relations.md

zecakeh mentioned this pull request May 17, 2022

events: Add unstable support for reference relations ruma/ruma#1119

Closed

turt2live removed the needs-implementation This MSC does not have a qualifying implementation for the SCT to review. The MSC cannot enter FCP. label May 20, 2022

turt2live added 2 commits May 19, 2022 19:48

Apply formatting

a5a2c61

Convert to point at present rather than ideal

62b5b0f

turt2live marked this pull request as ready for review May 20, 2022 01:53

clokep reviewed May 27, 2022

View reviewed changes

fix a typo

2c2d6ae

anoadragon453 approved these changes Jul 5, 2022

View reviewed changes

richvdh reviewed Jul 12, 2022

View reviewed changes

mscbot added final-comment-period Process state to accept, reject, or postpone an MSC. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the FCP. Process state. labels Jul 12, 2022

mscbot added finished-final-comment-period FCP has finished. Process state. and removed disposition-merge Process state. final-comment-period Process state to accept, reject, or postpone an MSC. labels Jul 17, 2022

turt2live merged commit 3f0ba9c into old_master Jul 17, 2022

turt2live added spec-pr-missing MSC is accepted, but missing spec PR. Process state. and removed finished-final-comment-period FCP has finished. Process state. labels Jul 17, 2022

turt2live self-assigned this Aug 3, 2022

turt2live added a commit to matrix-org/matrix-spec that referenced this pull request Aug 9, 2022

Spec reference relationships

22a11b3

MSC: matrix-org/matrix-spec-proposals#3267

turt2live mentioned this pull request Aug 9, 2022

Spec reference relationships matrix-org/matrix-spec#1206

Merged

turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing MSC is accepted, but missing spec PR. Process state. labels Aug 9, 2022

turt2live added merged A proposal whose PR has merged into the spec! Process state. and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels Oct 18, 2022

clokep mentioned this pull request Nov 18, 2022

Support Matrix v1.5 matrix-org/synapse#14486

Closed

2 tasks

zecakeh mentioned this pull request Nov 25, 2022

events: Add support for bundled reference relations ruma/ruma#1391

Merged

S7evinK mentioned this pull request Oct 2, 2023

Declare support for Matrix 1.5 matrix-org/dendrite#3223

Open

3 tasks

matrixbot mentioned this pull request Nov 1, 2024

Declare support for Matrix 1.5 element-hq/dendrite#3223

Open

3 tasks


		## Server aggregation

		[MSC2674](https://github.com/matrix-org/matrix-doc/pull/2674) states

Uh oh!

Conversation

bwindels commented Jul 5, 2021 • edited by turt2live Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

uhoreg commented Jul 5, 2021

Uh oh!

Uh oh!

Uh oh!

jplatte commented May 17, 2022

Uh oh!

turt2live commented May 17, 2022

Uh oh!

turt2live commented May 20, 2022

Uh oh!

turt2live commented May 20, 2022

Uh oh!

clokep May 27, 2022

Choose a reason for hiding this comment

Uh oh!

anoadragon453 Jul 5, 2022

Choose a reason for hiding this comment

Uh oh!

anoadragon453 Jul 5, 2022

Choose a reason for hiding this comment

Uh oh!

anoadragon453 Jul 5, 2022

Choose a reason for hiding this comment

Uh oh!

anoadragon453 Jul 5, 2022

Choose a reason for hiding this comment

Uh oh!

richvdh Jul 12, 2022

Choose a reason for hiding this comment

Uh oh!

mscbot commented Jul 12, 2022

Uh oh!

mscbot commented Jul 17, 2022

Uh oh!

turt2live commented Aug 9, 2022

Uh oh!

turt2live commented Oct 18, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

bwindels commented Jul 5, 2021 •

edited by turt2live

Loading