feat(sdk): add support for thread subscription endpoints (MSC4306) - #5439
Merged
Conversation
bnjbvr
force-pushed
the
bnjbvr/thread-subs
branch
from
July 23, 2025 18:00
b90eabf to
e2378bf
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5439 +/- ##
==========================================
- Coverage 88.89% 88.88% -0.01%
==========================================
Files 333 333
Lines 91884 91993 +109
Branches 91884 91993 +109
==========================================
+ Hits 81677 81768 +91
- Misses 6376 6390 +14
- Partials 3831 3835 +4 ☔ View full report in Codecov by Sentry. |
bnjbvr
force-pushed
the
bnjbvr/thread-subs
branch
3 times, most recently
from
July 24, 2025 15:12
00c89c9 to
c93af79
Compare
bnjbvr
marked this pull request as ready for review
July 24, 2025 15:13
bnjbvr
force-pushed
the
bnjbvr/thread-subs
branch
from
July 24, 2025 15:22
c93af79 to
c46046b
Compare
andybalaam
approved these changes
Jul 25, 2025
andybalaam
left a comment
andybalaam
left a comment
Member
There was a problem hiding this comment.
Looks good - some small questions. Thanks!
bnjbvr
force-pushed
the
bnjbvr/thread-subs
branch
from
July 28, 2025 08:24
c46046b to
4cc5f48
Compare
bnjbvr
enabled auto-merge (rebase)
July 28, 2025 08:24
This doesn't store the subscriptions locally, nor does it implement the automatic thread subscription.
…he current sub status
bnjbvr
force-pushed
the
bnjbvr/thread-subs
branch
from
July 28, 2025 08:25
4cc5f48 to
51e7e84
Compare
Hywan
reviewed
Aug 13, 2025
| [MSC4306](https://github.com/matrix-org/matrix-spec-proposals/pull/4306), with the | ||
| `Room::fetch_thread_subscription()`, `Room::subscribe_thread()` and `Room::unsubscribe_thread()` | ||
| methods. | ||
| ([#5442](https://github.com/matrix-org/matrix-rust-sdk/pull/5442)) |
Hywan
added a commit
to Hywan/matrix-rust-sdk
that referenced
this pull request
Aug 13, 2025
The link for an entry was wrong. It's matrix-org#5439, not matrix-org#5442.
Contributor
Author
|
Feel free to PR :P
…On Wed, Aug 13, 2025 at 9:38 AM Ivan Enderlin ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In crates/matrix-sdk/CHANGELOG.md
<#5439 (comment)>
:
> @@ -8,6 +8,11 @@ All notable changes to this project will be documented in this file.
### Features
+- Add experimental support for
+ [MSC4306](matrix-org/matrix-spec-proposals#4306), with the
+ `Room::fetch_thread_subscription()`, `Room::subscribe_thread()` and `Room::unsubscribe_thread()`
+ methods.
+ ([#5442](#5442))
It's 5439, not 5442 :-D.
—
Reply to this email directly, view it on GitHub
<#5439 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJAC43ZCCVIQZ4PW4QJJQL3NLTN3AVCNFSM6AAAAACCF6PNP2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCMJUGMYTMNZXGA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the three new endpoints introduced by MSC4306, with tests and support in multiverse.
Depends on ruma/ruma#2169 and element-hq/synapse#18722.
Part of #4869 / #5038.