Add stable unstable feature for jump to date before v1.6 is fully supported on a homeserver - #10398
Conversation
MadLittleMods
added
the
T-Task
| defaultWatchManager, | ||
| ["org.matrix.msc3030"], | ||
| undefined, | ||
| [["org.matrix.msc3030"], ["org.matrix.msc3030.stable"]], |
There was a problem hiding this comment.
Add stable unstable version (org.matrix.msc3030.stable) for jump to date before v1.6 is fully supported on a homeserver.
org.matrix.msc3030.stable wasn't included in MSC3030 but it seems like pattern that should have been included like MSC2285 as an example.
Are we okay with moving forward with this?
There was a problem hiding this comment.
Related discussion matrix-org/synapse#15283 (comment)
| * @param unstableFeatureGroups - If any one of the feature groups is satisfied, | ||
| * then the setting is considered enabled. A feature group is satisfied if all of | ||
| * the features in the group are supported (all features in a group are required). | ||
| */ |
There was a problem hiding this comment.
As suggested by @t3chguy in #10398 (comment),
Guess it should be extended to string[][] where its an OR of AND groups to offer more flexibility
Refactoring ServerSupportUnstableFeatureController to support multiple feature groups where any one of them will enable the setting. All features in a feature group are required.
This way having either org.matrix.msc3030 or org.matrix.msc3030.stable will enable the jump to date feature flag with a config of [["org.matrix.msc3030"], ["org.matrix.msc3030.stable"]]
If you want to AND features together like before, just add them to the same group: [["foo", "bar"]]
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
Looks great, thanks for extending the controller
|
Related: element-hq/element-web#24362 |
|
@robintown Feel free to edit this type of info directly in the description |
…-for-jump-to-date Conflicts: src/settings/Settings.tsx
|
Thanks for the review @t3chguy and taking a look @robintown 🐮 |
…ported on Synapse Related to #15089 Element Web PR to honor `org.matrix.msc3030.stable`: matrix-org/matrix-react-sdk#10398
MadLittleMods
changed the title
v1.6 is fully supported on a homeserverv1.6 is fully supported on a homeserver
3 participants
Add stable unstable feature (
org.matrix.msc3030.stable) for jump to date beforev1.6is fully supported on a homeserver. Discussion for whether we are okay with moving forward with this -> #10398 (comment)Related to element-hq/element-web#24362 but does not solve immediately because Synapse does not supply
org.matrix.msc3030.stableyet. Synapse PR: matrix-org/synapse#15283Also refactored
ServerSupportUnstableFeatureControllerto support multiple feature groups where any one of them will enable the setting. All features in a feature group are required. See discussion -> #10398 (comment)Checklist
Sign-off given on the changes (see CONTRIBUTING.md)This change is marked as an internal change (Task), so will not be included in the changelog.