Fix MatrixRTC sender key wrapping - #4441
Merged
Merged
Conversation
toger5
approved these changes
Oct 2, 2024
toger5
left a comment
Contributor
There was a problem hiding this comment.
This makes a lot of sense if currentEncryptionKeyIndex is sth that is available to us anyways.
hughns
marked this pull request as ready for review
October 2, 2024 09:35
hughns
marked this pull request as draft
October 2, 2024 12:59
Member
Author
|
MSC4143 will actually mandate 256 indices, so this can stay for now. |
hughns
marked this pull request as ready for review
October 2, 2024 14:57
toger5
approved these changes
Oct 2, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 3, 2024
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.