Conversation
|
I've built mate-panel with this PR, but see no difference comparing to the previous build. What should be different, and how exactly to test this PR? |
|
This behavior would conflict with scrolling over other applets notable the window list as well as not being very discoverable. In x11 scrolling over the existing volume applet from mate-media already works. This would best be implemented as an alternative volume applet not whole panel scrolling |
|
Why do I see changes to the applet pack system as part of this PR? Are they necessary to accomodate this? |
|
At least one of the failed builds errored out with this message: |
|
I see the the word "codex" in the repo name. I suspect this is generated by AI I do not have the time to review this volume of code line by line and trace the entire flow of it in my head. I will never merge AI generated code where nobody including the author has done this as AI is known to hallucinate. There are also potential copyright issues such the AI training on a mix of BSD licensed and GPL code, meaning the output cannot be released under the GPL. Also note that this is cosmetically different from but does the same job as the volume applet we already have. Little benefit and could introduce new bugs-and is another marker of AI generated content. Closing until this is certified as human-written or as reviewed and understood line by line by the author |
Summary
Add optional native volume control to MATE panels.
Details
libpulse; builds without it and leaves the feature unavailable rather than adding a hard dependency.The existing MATE panel model already stores monitor and autohide state per
PanelToplevel, with independent timers. No duplicate panel implementation was added because that behavior is already native inmate-panel.Validation
gcc -fsyntax-onlyforpanel-volume.cwith libpulse enabled.gcc -fsyntax-onlyforpanel-volume.cwith libpulse unavailable.git diff --check.A complete current-master build is blocked on this Ubuntu installation because the installed
mate-desktopis 1.26.2 while this branch's current master requires >= 1.28.2.