The install and remove scripts read "age_mover is not running" as "no mover
is running" and deleted /var/run/mover.pid. Unraid's own mover and
share_mover write that file too, so a plugin update during one of their
runs hid the run: a second mover could start on top of it, and "mover
stop", which Unraid calls when the array stops, reported "not running".
mover.pid is now removed only when its pid is not a mover, and only while
the file still holds that pid. A run the plugin started (age_mover,
share_mover, or with_scripts from the before script on) keeps all its
files and blocks removal. Unraid's own mover keeps its pid file and does
not block removal.
/var/run/mover.pidunlessage_moverwas running. Unraid's own mover and a share's Move write that file too.mover stop(which Unraid runs when the array stops) answered "not running", and the Mover Tuning tab showed no run.age_moverstarted the old and the new way, a run still in its before script, a mover that starts during the cleanup, and stale, reused and unreadable pid files. The old code fails eight of them.Summary by CodeRabbit