Skip to content

Don't skip scheduled moves while a parity check is paused - #268

Merged
chodeus merged 1 commit into
masterwishx:betafrom
chodeus:fix/paused-check-gate
Nov 5, 2026
Merged

chodeus merged 1 commit into
masterwishx:betafrom
chodeus:fix/paused-check-gate

Conversation

@chodeus

@chodeus chodeus commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

A paused check, rebuild or clear keeps mdResyncPos above 0, so with either "run during a parity check / rebuild" option on No, every scheduled run was skipped until the check was resumed or cancelled.

  • mover.php: both gates count a check as running only while mdResync is above 0, the value Unraid's Pause/Resume button reads.
  • Help text for both options: "A paused check or rebuild does not count."
  • Tested: both run paths × both settings × running / paused / idle / no var.ini, on PHP 7.4, 8.4 and 8.5. beta fails the 2 paused cases; this branch passes all 16.
  • To test: pause a check, set the option to No, and wait for a scheduled run. It starts instead of logging "Parity Check / rebuild in progress".

Summary by CodeRabbit

  • Bug Fixes
    • Scheduled and forced moves are no longer blocked by paused parity checks, rebuilds, or clears.
  • Documentation
    • Updated scheduling descriptions to clarify that paused parity operations do not count as active.

A paused check, rebuild or clear keeps mdResyncPos above 0, so with either
parity option on No every scheduled run was skipped until the check was
resumed or cancelled. Both gates now read mdResync, which is 0 while paused.
@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Explain Change →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 55 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 3b76d42 and e4f9034.

Files selected for processing: 3

  • source/ca.mover.tuning/usr/local/emhttp/plugins/ca.mover.tuning/Mover.tuning.page
  • source/ca.mover.tuning/usr/local/emhttp/plugins/ca.mover.tuning/languages/en_US.txt
  • source/ca.mover.tuning/usr/local/emhttp/plugins/ca.mover.tuning/mover.php

No actionable comments were generated in the recent review.

Walkthrough

The mover now treats parity/resync work as active only when integer mdResync is greater than zero. Forced and scheduled moves with parity disabled use this test. English descriptions clarify that paused checks and rebuilds do not count; the page help text remains unchanged.

Changes: Mover parity checks

Layer / File(s) Summary
Active-state predicate and move gates
source/ca.mover.tuning/usr/local/emhttp/plugins/ca.mover.tuning/mover.php, source/ca.mover.tuning/usr/local/emhttp/plugins/ca.mover.tuning/languages/en_US.txt, source/ca.mover.tuning/usr/local/emhttp/plugins/ca.mover.tuning/Mover.tuning.page
resyncRunning() returns true when integer mdResync is greater than zero. Forced and scheduled move gates use this check. English descriptions clarify that paused checks and rebuilds do not count. The page help text remains unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: masterwishx

Merge Risk: Minimal · up to e4f90

The change aligns move gating with the available mdResync state contract, with no concrete merge-blocking risk identified.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title states the main change: scheduled moves are no longer skipped while a parity check is paused. The raw summary confirms that resyncRunning() in mover.php now uses mdResync > 0, so a paused ch…
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the main change: scheduled moves are no longer skipped while a parity check is paused. The raw summary confirms that resyncRunning() in mover.php now uses mdResync > 0, so a paused check, rebuild, or clear with mdResync at zero no longer blocks forced or scheduled moves with parity disabled. The objectives describe the same fix in PR #268. The title is specific, short, and free of file lists or vague terms.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 1 files. (2 skipped: 2 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 3b76d42 and e4f9034.

Files selected for processing: 3

  • source/ca.mover.tuning/usr/local/emhttp/plugins/ca.mover.tuning/Mover.tuning.page
  • source/ca.mover.tuning/usr/local/emhttp/plugins/ca.mover.tuning/languages/en_US.txt
  • source/ca.mover.tuning/usr/local/emhttp/plugins/ca.mover.tuning/mover.php

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@chodeus

chodeus commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai full review

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 55 minutes.

@chodeus
chodeus merged commit 02c7f3a into masterwishx:beta Nov 5, 2026
10 checks passed
@chodeus
chodeus deleted the fix/paused-check-gate branch November 5, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant