This repository was archived by the owner on Aug 12, 2021. It is now read-only.
don't cache more than 1024 entries, to avoid DoS attacks - #5
Open
marten-seemann wants to merge 1 commit into
Open
marten-seemann wants to merge 1 commit into
marten-seemann wants to merge 1 commit into
Conversation
marten-seemann
force-pushed
the
dos-protect-sent-entries2
branch
from
July 2, 2021 19:55
9c354b9 to
a0bfb77
Compare
Stebalien
approved these changes
Jul 2, 2021
| // DoS protection: don't cache more than maxSentEntries entries | ||
| if len(sentEntries) >= maxSentEntries { | ||
| for key := range sentEntries { | ||
| delete(sentEntries, key) |
Collaborator
There was a problem hiding this comment.
Also: we can just store a set, right? No need to store the values.
Collaborator
There was a problem hiding this comment.
Otherwise, a small number of entries could still be large.
Owner
Author
There was a problem hiding this comment.
Let's do that in a separate PR.
marten-seemann
force-pushed
the
dos-protect-sent-entries2
branch
from
July 2, 2021 21:19
a0bfb77 to
6e55e42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a copy of grandcat#94.
The size of the
sentEntriesmap needs to be limited, otherwise an attacker can consume unbounded state.The solution implemented here is very simple, but given Go's lack of data structures, any more sophisticated solution would require keeping track of a lot more state: The cache is deleted when it overflows.
@Stebalien, could you review this PR?