Repository navigation
Fix <Toolbar> design - #10960
Fix <Toolbar> design#10960
<Toolbar> design#10960Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the toolbar design by updating the background color from a semi-transparent divider color to a solid background color to improve visibility when the toolbar is sticky on mobile devices.
Key changes:
- Changed toolbar background from transparent divider color to solid background color
- Added theme-specific toolbar background colors for light, dark, and soft themes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/ra-ui-materialui/src/theme/defaultTheme.ts | Added RaToolbar component overrides with solid background colors for light (grey[100]) and dark (grey[900]) themes |
| packages/ra-ui-materialui/src/form/Toolbar.tsx | Changed default toolbar background from divider color to background.paper |
| examples/demo/src/themes/softTheme.ts | Added RaToolbar override with solid background color for soft dark theme |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
You PR changes the background color of the toolbar in some themes (e.g. B&W). |
I reviewed all themes again, there are now some subtle differences due to the removal of opacity but it should be close enough. Note that the chipTune theme was actually broken in production. I fixed it as well |
Problem
Fixes #10959.
The toolbar has a background color with some transparency (introduced here).
This does not look good on mobile for instance where it is sticky. This can be seen on this story, if you make your screen small enough so that the toolbar is sticky and you can scroll:
Solution
How To Test
For each theme:
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.