Repository navigation
[Doc] Fix <BulkActionsToolbar selectAllButton> only accepts an element - #10954
Merged
Merged
Conversation
slax57
changed the title
<BulkActionsToolbar selectAllButton> only accepts an element<BulkActionsToolbar selectAllButton> only accepts an element
djhi
approved these changes
Sep 23, 2025
djhi
reviewed
Sep 23, 2025
djhi
left a comment
djhi
left a comment
Contributor
There was a problem hiding this comment.
I don't see any good reason to not accept a ReactNode btw. Shouldn't we change it?
slax57
changed the title
<BulkActionsToolbar selectAllButton> only accepts an element<BulkActionsToolbar> to accept a Component Type as selectAllButton prop
slax57
force-pushed
the
doc-fix-selectAllButton
branch
from
September 25, 2025 08:19
d5f1860 to
984f19b
Compare
slax57
changed the title
<BulkActionsToolbar> to accept a Component Type as selectAllButton prop<BulkActionsToolbar selectAllButton> only accepts an element
djhi
approved these changes
Sep 25, 2025
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
<BulkActionsToolbar selectAllButton>only accepts an element, but doc gives an exemple where a React Component is passed, which doesn't work (and actually even TS complains about)Solution
Fix the doc.
Also, update the props type to accept a
ReactNodewhile we're at it.Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.