Repository navigation
Fix passing an element to notify requires to wrap it in forwardRef - #10935
Merged
Merged
Conversation
Madeorsk
self-requested a review
September 12, 2025 13:03
Madeorsk
requested changes
Sep 12, 2025
djhi
commented
Sep 12, 2025
Madeorsk
approved these changes
Sep 12, 2025
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Even though our story does it, our documentation does not mention that you have to wrap your notification element in a
forwardRef.We could fix the documentation but requiring our users to think about this isn't great.
Solution
Notificationcomponent.The wrapping
divdoes not even appear in the DOM.How To Test
forwardRef.Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a featureAlso, please make sure to read the contributing guidelines.