Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/ra-core/src/controller/button/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ import useDeleteWithConfirmController from './useDeleteWithConfirmController';

export { useDeleteWithUndoController, useDeleteWithConfirmController };
export * from './useDeleteController';
export * from './useBulkDeleteController';
117 changes: 117 additions & 0 deletions packages/ra-core/src/controller/button/useBulkDeleteController.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,117 @@
import { useCallback, useMemo } from 'react';
import {
useDeleteMany,
UseDeleteManyOptions,
} from '../../dataProvider/useDeleteMany';
import { useRefresh } from '../../dataProvider/useRefresh';
import { useListContext } from '../list/useListContext';
import { useNotify } from '../../notification/useNotify';
import { RaRecord, MutationMode } from '../../types';
import { useResourceContext } from '../../core/useResourceContext';
import { useTranslate } from '../../i18n/useTranslate';

export const useBulkDeleteController = <
RecordType extends RaRecord = any,
ErrorType = Error,
>(
props: UseBulkDeleteControllerParams<RecordType, ErrorType>
): UseBulkDeleteControllerReturn => {
const {
mutationMode = 'undoable',
mutationOptions = {},
successMessage,
} = props;
const { meta: mutationMeta, ...otherMutationOptions } = mutationOptions;
const resource = useResourceContext(props);
const notify = useNotify();
const refresh = useRefresh();
const translate = useTranslate();
const { selectedIds, onUnselectItems } = useListContext();

const [deleteMany, { isPending }] = useDeleteMany<RecordType, ErrorType>(
resource,
undefined,
{
onSuccess: () => {
notify(
successMessage ??
`resources.${resource}.notifications.deleted`,
{
type: 'info',
messageArgs: {
smart_count: selectedIds.length,
_: translate('ra.notification.deleted', {
smart_count: selectedIds.length,
}),
},
undoable: mutationMode === 'undoable',
}
);
onUnselectItems();
},
onError: (error: any) => {
notify(
typeof error === 'string'
? error
: error?.message || 'ra.notification.http_error',
{
type: 'error',
messageArgs: {
_:
typeof error === 'string'
? error
: error?.message,
},
}
);
refresh();
},
}
);

const handleDelete = useCallback(() => {
deleteMany(
resource,
{
ids: selectedIds,
meta: mutationMeta,
},
{
mutationMode,
...otherMutationOptions,
}
);
}, [
deleteMany,
mutationMeta,
mutationMode,
otherMutationOptions,
resource,
selectedIds,
]);

return useMemo(
() => ({
isPending,
isLoading: isPending,
handleDelete,
}),
[isPending, handleDelete]
);
};

export interface UseBulkDeleteControllerParams<
RecordType extends RaRecord = any,
MutationOptionsError = unknown,
> {
mutationMode?: MutationMode;
mutationOptions?: UseDeleteManyOptions<RecordType, MutationOptionsError>;
resource?: string;
successMessage?: string;
}

export interface UseBulkDeleteControllerReturn {
isLoading: boolean;
isPending: boolean;
handleDelete: () => void;
}
30 changes: 9 additions & 21 deletions packages/ra-core/src/controller/button/useDeleteController.tsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import { useCallback, useMemo } from 'react';
import { UseMutationOptions } from '@tanstack/react-query';

import { useDelete } from '../../dataProvider';
import { useUnselect } from '../';
import { useDelete, UseDeleteOptions } from '../../dataProvider';
import { useRecordContext, useUnselect } from '../';
import { useRedirect, RedirectionSideEffect } from '../../routing';
import { useNotify } from '../../notification';
import { RaRecord, MutationMode, DeleteParams } from '../../types';
import { RaRecord, MutationMode } from '../../types';
import { useResourceContext } from '../../core';
import { useTranslate } from '../../i18n';

Expand All @@ -14,8 +13,6 @@ import { useTranslate } from '../../i18n';
*
* @example
* const DeleteButton = ({
* resource,
* record,
* redirect,
* ...rest
* }) => {
Expand All @@ -24,8 +21,6 @@ import { useTranslate } from '../../i18n';
* handleDelete,
* } = useDeleteController({
* mutationMode: 'pessimistic',
* resource,
* record,
* redirect,
* });
*
Expand Down Expand Up @@ -67,13 +62,13 @@ export const useDeleteController = <
props: UseDeleteControllerParams<RecordType, ErrorType>
): UseDeleteControllerReturn => {
const {
record,
redirect: redirectTo = 'list',
mutationMode,
mutationMode = 'undoable',
mutationOptions = {},
successMessage,
} = props;
const { meta: mutationMeta, ...otherMutationOptions } = mutationOptions;
const record = useRecordContext(props);
const resource = useResourceContext(props);
const notify = useNotify();
const unselect = useUnselect(resource);
Expand Down Expand Up @@ -102,21 +97,18 @@ export const useDeleteController = <
record && unselect([record.id]);
redirect(redirectTo, resource);
},
onError: error => {
onError: (error: any) => {
notify(
typeof error === 'string'
? error
: (error as Error)?.message ||
'ra.notification.http_error',
: error?.message || 'ra.notification.http_error',
{
type: 'error',
messageArgs: {
_:
typeof error === 'string'
? error
: (error as Error)?.message
? (error as Error).message
: undefined,
: error?.message,
},
}
);
Expand Down Expand Up @@ -166,11 +158,7 @@ export interface UseDeleteControllerParams<
MutationOptionsError = unknown,
> {
mutationMode?: MutationMode;
mutationOptions?: UseMutationOptions<
RecordType,
MutationOptionsError,
DeleteParams<RecordType>
>;
mutationOptions?: UseDeleteOptions<RecordType, MutationOptionsError>;
record?: RecordType;
redirect?: RedirectionSideEffect;
resource?: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {
CoreAdminContext,
testDataProvider,
ListContextProvider,
MutationMode,
} from 'ra-core';
import { createTheme, ThemeProvider } from '@mui/material/styles';

Expand All @@ -13,7 +14,11 @@ export default { title: 'ra-ui-materialui/button/BulkDeleteWithConfirmButton' };

const theme = createTheme();

export const Default = () => {
export const Default = ({
mutationMode = 'pessimistic',
}: {
mutationMode?: MutationMode;
}) => {
const dataProvider = testDataProvider({
deleteMany: async () => ({ data: [{ id: 123 }] as any }),
});
Expand All @@ -31,11 +36,24 @@ export const Default = () => {
>
<BulkDeleteWithConfirmButton
resource="books"
mutationMode="pessimistic"
mutationMode={mutationMode}
/>
<Notification />
</ListContextProvider>
</ThemeProvider>
</CoreAdminContext>
);
};

Default.args = {
mutationMode: 'pessimistic',
};

Default.argTypes = {
mutationMode: {
options: ['pessimistic', 'optimistic', 'undoable'],
control: {
type: 'select',
},
},
};
Loading