Add safe edit mode#2
Draft
marcus-pousette wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on cybersemics#175.
This PR adds a conservative edit mode for the undo/redo helper API introduced in cybersemics#175.
mode: 'force' | 'safe'toedits.undo(...)andedits.redo(...).forceas the default behavior from History-derived undo plans cybersemics/treecrdt#175.safemode, which checks that the current visible state still matches the captured edit's post-state before writing undo/redo ops.EditConflictErrorand writes no operations when safe mode detects a changed visible state.Semantics
forceis git-revert-style behavior: always append inverse operations, even if that overwrites a later change to the same visible field.safeis the conservative collaborative behavior: reject before writing if another local or remote edit changed the same visible node state after the edit was captured.This PR intentionally keeps the policy in the TypeScript
editshelper. The backendhistory.invert(...)trait remains responsible only for deriving inverse plans.Verification
pnpm -C packages/treecrdt-ts run buildpnpm -C packages/treecrdt-engine-conformance run buildpnpm -C packages/treecrdt-sqlite-node exec vitest run tests/conformance.test.tspnpm -C packages/treecrdt-wa-sqlite exec vitest run tests/node-client.test.ts