Skip to content

Error on unknown child node with jump to#25

Open
Grummfy wants to merge 1 commit into
marcelog:masterfrom
Grummfy:error-on-empty-jumpTo
Open

Error on unknown child node with jump to#25
Grummfy wants to merge 1 commit into
marcelog:masterfrom
Grummfy:error-on-empty-jumpTo

Conversation

@Grummfy

@Grummfy Grummfy commented Aug 25, 2014

Copy link
Copy Markdown

Hi,
On a node result I had an error, because I was not reading the docs ... so I was useing jumpAfterEval instead of execute ... but it appears that the PAGI libs let sme erreors happends, so here is the fix.

Comment thread .gitignore Outdated

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't belong to this pull

@marcelog

Copy link
Copy Markdown
Owner

hi!

please make sure you only include the needed change, and that it's unit tested. please don't include any identation changes, and try to follow the style of the original code.

cheers!

@marcelog marcelog closed this Aug 25, 2014
@marcelog marcelog reopened this Aug 25, 2014
@marcelog

Copy link
Copy Markdown
Owner

sorry that i closed it by mistake. feel free to rebase and push force for this same pull

@Grummfy
Grummfy force-pushed the error-on-empty-jumpTo branch from b28709f to 4f66544 Compare January 20, 2015 14:50
@Grummfy
Grummfy force-pushed the error-on-empty-jumpTo branch from 4f66544 to ae4e98a Compare January 20, 2015 15:01
@Grummfy

Grummfy commented Jan 20, 2015

Copy link
Copy Markdown
Author

here it is the cleaned one

@Grummfy
Grummfy force-pushed the error-on-empty-jumpTo branch from ae4e98a to 6ddbc0c Compare January 20, 2015 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants