Fixes to make it compatible with phantomjs 2.0.0#169
Open
nagaozen wants to merge 1 commit intomarcelduran:masterfrom
Open
Fixes to make it compatible with phantomjs 2.0.0#169nagaozen wants to merge 1 commit intomarcelduran:masterfrom
nagaozen wants to merge 1 commit intomarcelduran:masterfrom
Conversation
phantom.args deprecated in favor of system.args phantom.scriptName deprecated in favor of system.args[0]
|
Thank you @nagaozen, this fix works great for me (using phantomjs 2.1.1 on macOS Sierra). This PR is duplicated with #156 from @Staniiiik with the improving that this current PR also fixes the script name arguments. I hope @marcelduran may help us with evaluating and merging this fix. By the way thank you for this great piece of software, it works great for us at www.talenteca.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phantom.args deprecated in favor of system.args
phantom.scriptName deprecated in favor of system.args[0]