Resolves issue #74 - implement "2x" images on retina devices#79
Open
leptos-null wants to merge 1 commit into
Open
Resolves issue #74 - implement "2x" images on retina devices#79leptos-null wants to merge 1 commit into
leptos-null wants to merge 1 commit into
Conversation
|
Beginning at 1084, most comics are Retina, but a few before that are also Retina, such as 1053 and 1061. |
|
Adding to the dataset: Today I tested all comics from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To appropriately implement "retina" images, the device screen scale is checked. #74 mentions
1084being the first supported comic. If both these conditions are met, the string representing the URL is modified. Another option for the string manipulation isNSString *patchingImageString = [self.imageURLString stringByDeletingPathExtension]; patchingImageString = [patchingImageString stringByAppendingString:@"_2x"] self.imageURLString = [patchingImageString stringByAppendingPathExtension:@"png"];The above approach is more clear, however I felt that the performance trade-offs were not worth using it.