logging: classify bare rate-limit messages as transient - #710
Open
ben-dz wants to merge 1 commit into
Open
Conversation
The DZ ledger RPC (rpcpool) surfaces HTTP 429 as a jsonrpc error dump whose message is "Connection rate limits exceeded" - neither "rate limited" nor "status 429" substring-matches it, so it classified as Unknown/non-transient and escalated at the strict threshold (3) instead of the transient one (10). Observed during the 2026-07-23 testnet permission-events drain, where a mid-drain 429 logged as if actionable. Broaden the pattern to "rate limit", covering "rate limited", "rate limits exceeded", and "rate limiting": an error mentioning rate limits is a throttle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
dberror's rate-limit pattern from"rate limited"to"rate limit", so messages like rpcpool's HTTP 429 body —Connection rate limits exceeded, surfaced through the jsonrpc client's error dump where neither"rate limited"nor"status 429"substring-match — classify asErrorTypeRateLimit/transient. The broader pattern also covers"rate limiting".Diff Breakdown
One pattern broadened, pinned by table-test cases.
Testing Verification
Classify→ErrorTypeRateLimitandIsTransient→ true for the exact prod error text (jsonrpc dump format withConnection rate limits exceeded) and a"rate limiting"variant; existing cases confirm"rate limited"and"status 429"still classify unchanged.utils/...suite passes with-race.