Skip to content

offchain: sync the three commits that landed after the import - #4257

Merged
bgm-malbeclabs merged 4 commits into
mainfrom
migrate/offchain-sync
Sep 2, 2026
Merged

offchain: sync the three commits that landed after the import#4257
bgm-malbeclabs merged 4 commits into
mainfrom
migrate/offchain-sync

Conversation

@bgm-malbeclabs

Copy link
Copy Markdown
Contributor

Stacked on #4256, top of the migration stack, so the diff shown here is the sync alone.

#4240 captured doublezero-offchain at its #414. Three pull requests landed there afterwards, so the imported tree went in three commits stale. This replays them.

Summary

  • offchain#415 removes doublezero-solana shreds pay. withdraw, list, payments and price stay. This is the other half of Remove FeedSeatPay QA e2e from doublezero #4248 in this repo, which removed the QA e2e that funded a seat through it.
  • offchain#416 removes the fund-seat instruction from the offchain Solana SDK, while shreds payments keeps reading leftover fund-seat transactions so history stays legible.
  • offchain#417 moves the solana-cli crate to 0.5.12.
  • Each commit keeps its original author, date and message. The bare (#N) references are rewritten to name malbeclabs/doublezero-offchain, exactly as the import rewrote its own 451, so a reader following a link does not land on an unrelated pull request in this repo.
  • offchain/Cargo.lock is left out of the replay, because workspace: fold the offchain crates into the root workspace #4255 deleted it. The version bump it carried lands in the root lockfile instead, which is where the crate resolves now.
  • solana/ needs no sync. Its upstream tip is the tip that was imported.

Testing Verification

  • git diff between offchain/crates here and the same tree at upstream main comes back to exactly the files steps 3, 4 and 5 changed, and nothing else: the manifests, the clippy fixes, and step 3's feed_pks compatibility change. Nothing upstream is missing and nothing extra crept in.
  • cargo clippy -p doublezero-solana-cli -p doublezero-solana-sdk --all-targets with this repo's lint line: clean.
  • cargo test for both crates: 161 passed.
  • Nothing outside offchain/ referenced the removed command. The only match in the repo is a CHANGELOG line describing Remove FeedSeatPay QA e2e from doublezero #4248, which is a historical note.

Note for whoever reads the per-crate changelogs

The changelog text these commits add still carries bare (#N) references, because the import rewrote commit messages only and left file contents alone. Every imported per-crate changelog is like this. Rewriting them is a separate job, if it is worth doing at all.

@bgm-malbeclabs
bgm-malbeclabs force-pushed the migrate/offchain-sync branch 2 times, most recently from 551edc0 to e822d07 Compare September 1, 2026 23:00
@bgm-malbeclabs
bgm-malbeclabs force-pushed the migrate/offchain-sync branch 4 times, most recently from d02089a to 255bafc Compare September 2, 2026 01:06
Base automatically changed from migrate/merge-ci to main September 2, 2026 01:57
@bgm-malbeclabs
bgm-malbeclabs requested a review from a team September 2, 2026 01:57
martinsander00 and others added 4 commits September 1, 2026 19:01
Resolves: malbeclabs/infra#2410

## Summary

- `doublezero-solana shreds pay` is gone.
- `doublezero-solana shreds withdraw`, `list`, `payments`, and `price`
stay.

## Testing

- Run `doublezero-solana shreds --help` and confirm `pay` is missing.
- Run `doublezero-solana shreds withdraw --help` and confirm withdraw is
still there.
…lezero-offchain#416)

Closes malbeclabs/infra#2410.

## Summary
- The Solana SDK no longer builds a fund-seat instruction.
- `doublezero-solana shreds payments` still reads leftover fund
transactions so escrow history stays intact.
- Close and withdraw stay so a holder can pull unused USDC.
## Summary
- The CLI crate version moves from 0.5.10 to 0.5.12.
- The changelog records the CLI changes since the 0.5.11 tag.

## Testing
- This PR only changes the crate version, the changelog, and the
lockfile.
- Pushing `doublezero-solana/v0.5.12` after merge is what publishes
0.5.12.
`doublezero-offchain` merged #415, #416 and #417 after the import in #4240
captured its main at #414, so the imported tree was three commits behind. This
replays them into `offchain/`, keeping each commit's author, date and message,
with the bare pull request references rewritten to name the source repository
exactly as the import rewrote its own 451.

`offchain/Cargo.lock` is excluded from the replay, because step 4 deleted it.
The version bump it carried lands in the root lockfile instead, which is where
the crate resolves now.

`solana/` needs no sync: its upstream tip is the tip that was imported.
@bgm-malbeclabs
bgm-malbeclabs enabled auto-merge (squash) September 2, 2026 02:20
@bgm-malbeclabs
bgm-malbeclabs merged commit bae4dff into main Sep 2, 2026
39 checks passed
@bgm-malbeclabs
bgm-malbeclabs deleted the migrate/offchain-sync branch September 2, 2026 03:06
bgm-malbeclabs added a commit that referenced this pull request Sep 2, 2026
…4261)

Step 6 of the monorepo migration, the half that lives in this
repository. Archiving the two source repositories is an action on those
repositories, and the text to use is below. **Stacked on #4257**, so the
diff shown here is this change alone.

## Summary

- **`offchain/CONTRIBUTING.md` is removed.** It told contributors to
fork `doublezero-offchain` and to open pull requests and issues against
it. Both stop being true the moment that repository is archived: an
archived repository takes no issues and no pull requests. Everything
else in the file repeated the root README, and the one thing the root
lacked, the Contributor Covenant reference, moves there.
- **DEVELOPMENT gains a section on the two imported trees**, naming what
the root `make` targets do not reach: the Solana L1 programs, which keep
their own workspace, lockfile and 1.91 toolchain so their bytes stay
reproducible against `sha256sums_*.txt`, and the Elixir scheduler. Both
now have their own path-scoped CI, which the section names.

I checked the rest of both trees for pointers that stop being true after
the archive. There is only one other class, and it should stay: the
per-crate changelogs link to releases at `doublezero-offchain`. Those
releases exist there and an archived repository still serves them, so
the links keep working. Rewriting historical release links would make
them wrong, not right.

## For the archive itself

Both repositories keep their transfer redirects, their 11 forks and
their old release download URLs, so archive them read-only rather than
deleting. Suggested notice for the top of each README before archiving:

> **This repository has moved.** The code now lives in
> [malbeclabs/doublezero](https://github.com/malbeclabs/doublezero),
under `offchain/`,
> with its full history and its release tags. This repository is
archived and read-only.
> Open issues and pull requests against `malbeclabs/doublezero`.
>
> Existing releases and their download URLs continue to resolve here.
New releases are
> published from `malbeclabs/doublezero`.

Same text for `doublezero-solana`, with `solana/` as the directory.

Archiving is also what unblocks step 7, and the two are deliberately not
the same day: an archived repository still serves reads, so
`doublezero-shreds` keeps resolving `malbeclabs/doublezero-solana` at
tag `revenue-distribution/v0.3.7`, and that tag imported here points at
the same commit. Shreds can be repointed when it suits.

## Testing Verification

- Searched both imported trees for links to the source repositories
outside changelogs and release links. `offchain/CONTRIBUTING.md` was the
only live pointer; `offchain/Cargo.toml` also carried `repository` and
`homepage` fields naming the old repo, and #4255 deletes that file
outright.

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants