Skip to content

[INFRA-481] - feat(plane-enterprise): add Microsoft Teams integration secrets to silo #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akshat5302 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[INFRA-481] - feat(plane-enterprise): add Microsoft Teams integration secrets to silo #281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/plane-enterprise/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: Meet Plane. An Enterprise software development tool to manage issue

type: application

version: 3.1.0
version: 3.1.1
appVersion: "3.0.1"

home: https://plane.so/
Expand Down
28 changes: 28 additions & 0 deletions charts/plane-enterprise/questions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,34 @@ questions:
type: string
default: ""

- variable: services.silo.connectors.microsoft_teams.enabled
label: "Microsoft Teams Integration"
type: boolean
default: false
group: "Silo Connectors"
show_subquestion_if: true

@coderabbitai coderabbitai Bot Aug 7, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/usr/bin/env bash
set -euo pipefail

rg -n -C 2 'show_subquestion_if' charts/plane-enterprise/questions.yml
helm lint charts/plane-enterprise

Repository: makeplane/helm-charts

Length of output: 4572

🌐 Web query:

Rancher questions.yml show_subquestion_if field type string true

💡 Result:

In Rancher's questions.yml file, the show_subquestion_if field is a string used to define conditional logic for displaying subquestions [1][2]. When show_subquestion_if is set to "true" (as a string value), it means the associated subquestions will be rendered in the Rancher UI only when the parent question's value evaluates to true [1][3][4]. This is commonly used with boolean input types [3][5]. For example, if you have a boolean setting (e.g., enabled: true), setting show_subquestion_if: "true" on the parent question will cause the defined subquestions to appear when that setting is enabled [3][4]. Key technical details include: - Functionality: The field controls the visibility of the subquestions array based on the parent variable's value [1][2]. - Syntax: It accepts string values, such as "true" or specific option matches (e.g., "serviceType=NodePort") [1][2][4]. - Constraints: While show_subquestion_if is a standard field for question objects, it cannot be nested inside the subquestions array itself (i.e., subquestions cannot contain their own subquestions or show_subquestion_if keys) [1][2][6]. For more complex conditional requirements, the show_if field is used to control the visibility of the current variable itself based on other inputs [1][7].

Citations:

🌐 Web query:

site:gihub.com rancher/questions-yml-examples show_subquestion_if: true boolean Rancher

💡 Result:

In Rancher's questions.yml file, the show_subquestion_if field is used to conditionally display subquestions based on the value of a parent question [1][2][3]. When working with a boolean type question, you can use show_subquestion_if to trigger the visibility of nested subquestions when the boolean is set to true [1][2][3]. Usage Example: If you have a primary boolean question (e.g., enableFeature) and you want to show subquestions only when it is checked (true), your questions.yml configuration would look similar to this: questions: - variable: enableFeature label: "Enable Optional Feature" type: boolean default: false show_subquestion_if: "true" subquestions: - variable: featureOption label: "Feature Option" type: string default: "some-value" In this configuration, the subquestion featureOption will only appear in the Rancher UI when enableFeature is set to true [1][2][3]. Key Notes: - The show_subquestion_if field accepts a string representing the condition, such as "true" for boolean toggles [1][2][3]. - It can also be used for enum types by matching one of the defined options (e.g., show_subquestion_if: "OptionA") [1][2][3]. - Subquestions themselves cannot contain further nested subquestions or additional show_subquestion_if keys [1][2][3].

Citations:

Keep show_subquestion_if as a string.

show_subquestion_if is expected to hold a string condition, such as "true", so use show_subquestion_if: "true" instead of emitting a YAML boolean at this location.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@charts/plane-enterprise/questions.yml` at line 448, Update the
show_subquestion_if field in the question definition to use the string value
"true" rather than the YAML boolean true, preserving the expected string
condition format.

Source: MCP tools

subquestions:
- variable: services.silo.connectors.microsoft_teams.client_id
label: "MS Teams Client ID"
type: string
default: ""
- variable: services.silo.connectors.microsoft_teams.client_secret
label: "MS Teams Client Secret"
type: password
default: ""
- variable: services.silo.connectors.microsoft_teams.tenant_id
label: "MS Teams Tenant ID"
type: string
default: ""
- variable: services.silo.connectors.microsoft_teams.app_id
label: "MS Teams App ID"
type: string
default: ""
- variable: services.silo.connectors.microsoft_teams.app_type
label: "MS Teams App Type"
type: string
default: "MultiTenant"

- variable: services.monitor.pullPolicy
label: "Monitor Pull Policy"
type: enum
Expand Down
7 changes: 7 additions & 0 deletions charts/plane-enterprise/templates/config-secrets/silo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,13 @@ stringData:
SENTRY_CLIENT_SECRET: {{ .Values.services.silo.connectors.sentry.client_secret | default "" | quote }}
SENTRY_INTEGRATION_SLUG: {{ .Values.services.silo.connectors.sentry.integration_slug | default "" | quote }}
{{- end }}
{{- if .Values.services.silo.connectors.microsoft_teams.enabled }}
MS_TEAMS_CLIENT_ID: {{ .Values.services.silo.connectors.microsoft_teams.client_id | default "" | quote }}
MS_TEAMS_CLIENT_SECRET: {{ .Values.services.silo.connectors.microsoft_teams.client_secret | default "" | quote }}
MS_TEAMS_TENANT_ID: {{ .Values.services.silo.connectors.microsoft_teams.tenant_id | default "" | quote }}
MS_TEAMS_APP_ID: {{ .Values.services.silo.connectors.microsoft_teams.app_id | default "" | quote }}
MS_TEAMS_APP_TYPE: {{ .Values.services.silo.connectors.microsoft_teams.app_type | default "MultiTenant" | quote }}
{{- end }}
{{- end }}
---
{{- if .Values.services.silo.enabled }}
Expand Down
7 changes: 7 additions & 0 deletions charts/plane-enterprise/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,6 +377,13 @@ services:
client_id: ''
client_secret: ''
integration_slug: ''
microsoft_teams:
enabled: false
client_id: ''
client_secret: ''
tenant_id: ''
app_id: ''
app_type: 'MultiTenant'

email_service:
enabled: false
Expand Down