[INFRA-776] - fix(argus): address post-merge review feedback - #55
Open
akshat5302 wants to merge 1 commit into
Open
[INFRA-776] - fix(argus): address post-merge review feedback#55akshat5302 wants to merge 1 commit into
akshat5302 wants to merge 1 commit into
Conversation
- Route /argus/ via base nginx ingress and traefik ingress-route (mirrors /pi/);
update phoenix's index-coupled IngressRoute host patches accordingly
- Drop strategy: Recreate (default RollingUpdate like sibling services)
- Add startupProbe so slow DB connects don't turn into liveness CrashLoops
- Mount an emptyDir at /home/nonroot/data for CSV exports (distroless nonroot
image); teach custom-ca to append (not replace) argus volumes/volumeMounts
- Make ARGUS_TRUSTED_PROXIES and ARGUS_METRICS_ADDR overlay-configurable via
replacements + vars.yaml.example entries
- Broaden default overlay's APP_VERSION Job image target to unscoped kind: Job
(rejecting plane-minio-bucket-create) so plane-argus-migrator tracks APP_VERSION
- Fail-closed ARGUS_FINGERPRINT_SECRET examples ("" + generation/rotation notes);
ARGUS_DATABASE_URL examples now mirror each overlay's DATABASE_URL host with a
same-database + no-Secrets-Manager warning
- Fix migrator run-timestamp year and document Job template immutability
- Document argus in kustomize/README.md and phoenix README (required keys,
private image caveat); tighten default/managed commented-out entries
Co-Authored-By: WOZCODE <contact@withwoz.com>
|
Linked to Plane Work Item(s) This comment was auto-generated by Plane |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #53 (squash-merged before review comments landed). Addresses all 12 review comments from @gauthamp-ai and @pratapalakshmi:
/argus/→plane-argus:8100to base nginx ingress and the traefik IngressRoute (mirroring/pi/); phoenix's index-coupled IngressRoute host patches updated in the same commit per the file's own rule.strategy: Recreate(default RollingUpdate like siblings); add astartupProbeon/argus/healthzso a slow/hung DB connect no longer becomes a liveness CrashLoop; mount anemptyDirat/home/nonroot/dataso CSV exports work undernonroot-security-context(fsGroup) —custom-canow treats argus like email-service (append, not replace, volumes/volumeMounts).kind: Job(with arejectforplane-minio-bucket-create, which usesminio/mc) soplane-argus-migratortracks APP_VERSION like managed/phoenix.ARGUS_TRUSTED_PROXIESandARGUS_METRICS_ADDRare now overlay-configurable via replacements +vars.yaml.exampleentries in all three overlays.ARGUS_FINGERPRINT_SECRETexamples fail closed ("", with generation + rotation-warning comments);ARGUS_DATABASE_URLexamples mirror each overlay's ownDATABASE_URLhost and note it must target the same Plane database (argus has no Secrets Manager support).spec.templateimmutability (delete before re-apply); timestamp year fixed.kustomize/README.mdand the phoenix README (required keys, privatemakeplane/argus-cloudimage caveat); default/managed commented-out entries clarified as NOT enabled by default.Test plan
kubectl kustomizesucceeds for default, managed, and phoenix overlays (from.examplefiles)Recreate, startupProbe present,argus-data+custom-cavolumes coexist,/argus/traefik rule at correct index with subsequent routes intactplane-argus-wlandplane-argus-migrator;plane-minio-bucket-createuntouched🧙 Built with WOZCODE