Skip to content

Optimize bar damage - #1309

Merged
mahkoh merged 5 commits into
masterfrom
jorth/bar-damage
Oct 27, 2026
Merged

mahkoh merged 5 commits into
masterfrom
jorth/bar-damage

Conversation

@mahkoh

@mahkoh mahkoh commented Oct 27, 2026

Copy link
Copy Markdown
Owner

Fixes #1308

Copilot AI balanced review requested due to automatic review settings October 27, 2026 01:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No blocking issues were identified in visibility handling, transaction damage scheduling, or rectangle-union behavior.

No open issues 🎉

What changed in this PR

This PR reduces unnecessary status-bar rendering and output damage to address the frame drops reported in #1308.

Changes:

  • Tracks bar visibility in live and render state, skipping status-triggered rendering while hidden.
  • Avoids full-output damage for render-data-only transactions.
  • Makes rectangle unions handle empty rectangles directly, simplifying callers.
File Description
src/​tree/​output/​output_dfs_g_fuse.rs Exposes live and render title visibility in diagnostics.
src/​tree/​output.rs Gates bar updates by visibility and narrows transaction damage.
src/​rect.rs Handles empty rectangles in Rect::union.
src/​ifs/​wl_surface.rs Simplifies surface extent unions.
src/​cursor.rs Simplifies cursor damage extent unions.

Review effort: Balanced

@mahkoh
mahkoh enabled auto-merge October 27, 2026 01:59
@mahkoh
mahkoh merged commit 8ab314e into master Oct 27, 2026
14 checks passed
@mahkoh
mahkoh deleted the jorth/bar-damage branch October 27, 2026 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Status bar/pango rendering causes frame drops

2 participants