Repository navigation
Optimize bar damage - #1309
Merged
Merged
Optimize bar damage#1309
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues were identified in visibility handling, transaction damage scheduling, or rectangle-union behavior.
No open issues 🎉
What changed in this PR
This PR reduces unnecessary status-bar rendering and output damage to address the frame drops reported in #1308.
Changes:
- Tracks bar visibility in live and render state, skipping status-triggered rendering while hidden.
- Avoids full-output damage for render-data-only transactions.
- Makes rectangle unions handle empty rectangles directly, simplifying callers.
| File | Description |
|---|---|
src/tree/output/output_dfs_g_fuse.rs |
Exposes live and render title visibility in diagnostics. |
src/tree/output.rs |
Gates bar updates by visibility and narrows transaction damage. |
src/rect.rs |
Handles empty rectangles in Rect::union. |
src/ifs/wl_surface.rs |
Simplifies surface extent unions. |
src/cursor.rs |
Simplifies cursor damage extent unions. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1308