Repository navigation
feat: per-window theme overrides - #1128
michaeladler wants to merge 1 commit into
Conversation
4dee036 to
6417198
Compare
michaeladler
changed the title
|
|
|
Forget my previous comment. I had forgotten that this was supposed to be a per-window setting. In that case some more machinery might be required. We will probably want to build some general-purpose machinery that allows arbitrary theme settings to be overwritten on per-window basis. While this action would be ok for this particular situation, it would not do if in the future we want other things, like the border color, to be settable for each window. |
6417198 to
d803b1e
Compare
michaeladler
changed the title
|
I like that idea. I've updated my branch to allow per-window theme overrides. Seems to work fine so far. Once we agree upon the design I will update the docs. |
64c0710 to
d21bdac
Compare
|
|
This looks pretty good! |
d21bdac to
bc2c08e
Compare
|
Successfully tested latest version |
bc2c08e to
ebc35e8
Compare
ebc35e8 to
6dfdd9b
Compare
6dfdd9b to
ae40920
Compare
ae40920 to
41457b0
Compare
41457b0 to
8d6144f
Compare
8d6144f to
82e8bff
Compare
Theme properties can now be overridden per window via window rules, e.g.:
```toml
[[windows]]
match.app-id = "mpv"
action = { type = "set-window-theme", theme.border-width = 0 }
```
If several rules override the same property of a window, the rule that
appears last takes precedence.
82e8bff to
8721103
Compare
|
This required tons of refactorings to fully implement it. The final result is now in #1263. Please test it. |
Theme properties can now be overridden per window via window rules, e.g.:
If several rules override the same property of a window, the rule that appears last takes precedence.