feat: make max options displayed configurable per question (closes #80)#724
Open
SAY-5 wants to merge 1 commit into
Open
feat: make max options displayed configurable per question (closes #80)#724SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80.
Adds a per-question
max_options_displayed_at_onceparameter toListandCheckboxquestions. When unset (default), the existing 13-row window is preserved; when set to a positive integer it overrides the visible window size, letting users browse longer choice lists without truncation.The renderers (
_list.py,_checkbox.py) read the value through a property on the render class, so the module-levelMAX_OPTIONS_DISPLAYED_AT_ONCEconstant continues to define the default and other consumers are unaffected.Tests:
test_max_options_displayed_at_once_shows_more_choices(List, Checkbox): renders 40 choices withmax_options_displayed_at_once=25and asserts choices 0-24 are visible while choice 25 is windowed out.test_max_options_displayed_at_once_default_unchanged(List, Checkbox): confirms the default 13-row window still applies.TypeError: ... got an unexpected keyword argument 'max_options_displayed_at_once'if the source change is reverted.tests/integration/console_render/test_list.py + test_checkbox.py + tests/unitsuite: 98 passed, 2 skipped locally on Python 3.11.Docs: added a
max_options_displayed_at_oncesection todocs/usage.md.