Keep CI on the push-maintained maintenance branches#125
Merged
Conversation
Scoping the CI push trigger to the default branches removed the only coverage the long-lived maintenance branches had. This repository keeps a 2.x branch that is maintained by direct push, not by pull request, so pull_request provides nothing there and the branch silently lost its matrix run. The filter now also matches *.x and WIP, the two long-lived shapes in this family. Both are inert where such a branch does not exist, the same way master already is, so the idiom stays identical across the repositories. Short-lived feature branches keep losing their duplicate push run, which was the point of the original change — they are covered by their pull request.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the CI trigger change.
Scoping
ci.yml'spushtrigger to the default branches removed the only coverage the long-lived maintenance branches had. This repository keeps a2.xbranch maintained by direct push, not by pull request —gh pr list --base 2.x --state mergedis empty and its last CI run wasevent: push— sopull_requestprovides nothing there and the branch silently lost its matrix run.The filter now also matches
*.xandWIP, the two long-lived branch shapes in this family. Both are inert where such a branch does not exist, exactly asmasteralready is, so the idiom stays byte-identical across the repositories.Short-lived feature branches still lose their duplicate push run — that was the point of the original change, and they are covered by their pull request.
Caught by a workflow review of the pilot after this repository had already merged; the same correction is applied to every repository in the sweep.