Run CI once per pull request, not twice#124
Merged
Merged
Conversation
ci.yml triggered on both an unfiltered push and pull_request, so every push to a branch that also has an open pull request ran the whole matrix twice for the same commit — including the contexts that are required to merge. The push trigger is now scoped to the default branches, matching the sibling workflows in this repository that already do so. A pull request still produces its contexts through the unchanged pull_request trigger, so the required checks resolve exactly as before; a direct push to main and the post-merge state stay covered.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ci.ymlworkflow triggered on both an unfilteredpush:andpull_request:. For a branch with an open pull request both fire, so the whole matrix ran twice for the same commit — including the contexts required to merge.The
pushtrigger is now scoped to[main, master], matching sibling workflows in this repository that already do so. A pull request still produces its contexts through the unchangedpull_requesttrigger, so the required checks resolve exactly as before; a direct push tomainand the post-merge state stay covered.Part of a family-wide alignment: the same unfiltered trigger was present in 13 repositories.