magento/magento2#32599: Fix segfault when base URL config is empty - #41082
Open
swnsma wants to merge 1 commit into
Open
magento/magento2#32599: Fix segfault when base URL config is empty#41082swnsma wants to merge 1 commit into
swnsma wants to merge 1 commit into
Conversation
|
Hi @swnsma. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Stop infinite recursion in config placeholder processing when web/secure/base_url or web/unsecure/base_url is null or empty. Throw a clear LocalizedException instead of exhausting the stack.
swnsma
force-pushed
the
magento/magento2#32599
branch
from
August 4, 2026 05:46
8af2a1d to
4caa0e6
Compare
Contributor
Author
|
@magento run all tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixes infinite recursion (SIGSEGV / stack overflow) in store config placeholder processing when
web/secure/base_urlorweb/unsecure/base_urlisNULLor empty.Magento\Store\Model\Config\Placeholderpreviously kept recursing on unresolved{{secure_base_url}}/{{unsecure_base_url}}placeholders. It now throws a clear, localizableLocalizedExceptioninstead.Fixes #32599
Fixed Issues (if relevant)
Manual testing scenarios (*)
web/secure/base_urlincore_config_datatoNULL(ensure no higher-priority env override).bin/magento.Cannot resolve "{{secure_base_url}}" because "web/secure/base_url" is empty.Questions or comments
Unit and integration tests cover null/empty/missing base URL for both secure and unsecure placeholders, plus the scope-level
Processor\Placeholderpath.Contribution checklist (*)