magento/magento2#32468: Fix cart-fixed discount missing shipping VAT - #41078
Open
swnsma wants to merge 1 commit into
Open
magento/magento2#32468: Fix cart-fixed discount missing shipping VAT#41078swnsma wants to merge 1 commit into
swnsma wants to merge 1 commit into
Conversation
|
Hi @swnsma. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Apply remaining cart-fixed balance to shipping using the tax discount basis (including tax when configured). Multi-shipping cart-fixed detection and proportional totals are intentionally unchanged to minimize regression risk. Adds unit and integration coverage for the reported incl-tax path, coupon/shipping order, discount-never-exceeds-rule, and related tax configurations.
swnsma
force-pushed
the
magento/magento2#32468
branch
from
August 2, 2026 14:34
53cbd95 to
cc409c6
Compare
Contributor
Author
|
@magento run all tests |
Contributor
Author
|
@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Issues
Manual testing scenarios
Questions or comments
Single-shipping cart-fixed now seeds remaining balance after item allocation and caps shipping discount using the tax discount basis (
ShippingAmountForDiscountwhen set). Multi-shipping keeps the previous dual-gate detection and proportional formula to minimize regression surface.Includes unit tests and integration suite
CartFixedShippingTaxTestfor the ticket matrix, partial remaining, discount-never-exceeds-rule, and related tax configs.