magento/magento2#32292: Fix FilterPool crash on non-AbstractDb collections - #41054
Open
swnsma wants to merge 1 commit into
Open
magento/magento2#32292: Fix FilterPool crash on non-AbstractDb collections#41054swnsma wants to merge 1 commit into
swnsma wants to merge 1 commit into
Conversation
|
Hi @swnsma. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
FilterPool::applyFilters always called getSelect() after MC-24195, which fatals for UI grid collections that extend Framework Data\Collection only (API-backed / in-memory grids). Keep SQL WHERE regrouping for AbstractDb and restore the pre-2.4.2 applier-only path for other collections. Adds unit and integration coverage for both paths.
swnsma
force-pushed
the
magento/magento2#32292
branch
from
July 27, 2026 09:20
13dea33 to
e12b25e
Compare
Contributor
Author
|
@magento run all tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Issues
Manual testing scenarios
Magento\Framework\Data\Collectiononly (notAbstractDb), registered onCollectionFactory.Reporting::search/mui/index/renderfor that namespace).Call to undefined method ...::getSelect(); filters apply viaaddFieldToFilter.Questions or comments
FilterPool::applyFilters()was rewritten in 2.4.2 (MC-24195 /2638e0ff) to regroup SQLWHEREparts for correct OR-within-filter-group semantics. That path requiresAbstractDb::getSelect(), but the method still type-hints baseCollection.This change:
AbstractDbcollectionsAbstractDbcollections (existingReportingTestcontinues to cover DB OR groups)Related: #33119 (Braintree Settlement duplicate of the same root cause).