magento/magento2#31353: Materialize GraphQL product image cache with watermarks - #41052
Open
swnsma wants to merge 3 commits into
Open
magento/magento2#31353: Materialize GraphQL product image cache with watermarks#41052swnsma wants to merge 3 commits into
swnsma wants to merge 3 commits into
Conversation
GraphQL returned watermark-aware cache URLs without generating the files. Generate missing HASH-format cache variants (including watermarks) during image URL resolution so storefront GraphQL clients receive valid images.
|
Hi @swnsma. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
Contributor
Author
|
@magento run all tests |
Contributor
Author
|
@magento run all tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GraphQL product image resolvers returned watermark-aware cache URLs without generating the corresponding cache files. Theme-based
catalog:images:resizeonly buildsview.xmlsizes, so GraphQL variants (null width/height + watermark params) often 404 or resolve to placeholders.This change introduces
ProductImageCache, used by the media gallery URL resolver, to materialize missing HASH-format product image cache files (including watermarks) during GraphQL URL resolution.Fixed Issues
Manual testing scenarios
pub/media/catalog/product/cache(optional but recommended to force generation).image,small_image, andthumbnailURLs.small_image/thumbnail, which previously failed most often.Contribution checklist