hotfix(server/systems): Fixed collision detection on ApplyMovement system - #239
Merged
Conversation
PierreMarguerie
previously approved these changes
Jan 18, 2026
Shuvlyy
previously approved these changes
Jan 18, 2026
ElectronicIV
force-pushed
the
hotfix/systems/apply-movements
branch
from
January 18, 2026 16:15
07ca7a3 to
c4b242a
Compare
…::state to entity::state
PierreMarguerie
force-pushed
the
hotfix/systems/apply-movements
branch
from
January 18, 2026 17:07
4592090 to
66f7db6
Compare
Shuvlyy
approved these changes
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hotfix(server/systems): Fixed collision detection on ApplyMovement system
Issues closed
Closes #221
Summary
This pull request fix the collision detection on the ApplyMovement system of the server by handling horizontal and vertical movement separatly.
It also manage the movement of bullets and enemies.
Changes
Handles horizontal and vertical movement separatly.
Move enemies and bullets.
Detect when an enemy touch a player and kill the player and the enemy.
Detect when a bullet touch an enemy and kill the bullet and the enemy.
Breaking changes
Checklist
LabelsrtypeprojectStatus/Priority/Size/Start date/End dateMilestone