Skip to content

add support of row's color and backgroundcolor - #168

Open
SuperGod wants to merge 1 commit into
lxn:masterfrom
SuperGod:patch-1
Open

add support of row's color and backgroundcolor#168
SuperGod wants to merge 1 commit into
lxn:masterfrom
SuperGod:patch-1

Conversation

@SuperGod

Copy link
Copy Markdown

add two function,so user can controll each row's color and background color

add two function,so user can controll each row's color and background color
@lxn

lxn commented Nov 13, 2015

Copy link
Copy Markdown
Owner

Thanks for doing this, but I would like you to make some improvements:

  • Instead of the proposed TableRow struct and the two new color setter methods, use an approach like ImageProvider, maybe call it ColorProvider.
  • This ColorProvider interface would have to be handled in reflectmodels.go, as well.
  • Also please add yourself to the AUTHORS file.

Now I regret adding the AlternatingRowBGColor stuff, when it should have been done with a ColorProvider interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants