Repository navigation
feat(iutil): carry location and devices on Instance - #257
Merged
Merged
Conversation
Signed-off-by: Michał Lipski <michal@tallica.pl>
tallica
force-pushed
the
feat/instance-location-devices
branch
from
November 11, 2026 16:01
edbbf0f to
20912fb
Compare
tallica
marked this pull request as ready for review
November 11, 2026 16:01
Signed-off-by: Michał Lipski <michal@tallica.pl>
tallica
force-pushed
the
feat/instance-location-devices
branch
from
November 11, 2026 16:05
841988c to
b7f39aa
Compare
Member
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iutil.Instancedrops the cluster member an instance runs on and its devices, so a consumer cannot tell where an instance sits or what is attached to it.This adds both, read in
enricher.setInstance(devices expanded, falling back toDevicesasinterfaces()already does):Instance.Location(): the cluster member, empty off a cluster.Instance.Devices(): an iterator over cloned devices, read-only likeConfig().Equal,EqualNoNetsand the JSON wire form, so moving an instance to another member produces a changed event.NewInstancegainslocationanddevicesparameters; callers are updated.Motivation: jochumdev/incus-caddy-config#2 (templates that route through the member's address need
.Location).