avoid panics on adversarial filesystem input#1206
Open
curious-rabbit wants to merge 1 commit into
Open
Conversation
Three unwrap and expect sites could crash lsd on valid but unusual filesystem content. SymLink::from used expect on to_str which panics on non-utf8 symlink targets. GitCache::new unwrapped status_entry.path which is None for non-utf8 filenames. owner::truncate used byte-based String::truncate which panics on multibyte usernames. All three now handle the cases cleanly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three unwrap and expect sites could crash lsd on valid but unusual filesystem content.
SymLink::from used expect on to_str which panics on non-utf8 symlink targets. GitCache::new unwrapped status_entry.path which is None for non-utf8 filenames. owner::truncate used byte-based String::truncate which panics on multibyte usernames.