Handle permission errors when restore replaces existing files#2173
Open
kzaoaai wants to merge 1 commit into
Open
Handle permission errors when restore replaces existing files#2173kzaoaai wants to merge 1 commit into
kzaoaai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a restore crash when an existing destination path cannot be deleted due to filesystem permissions.
Problem
During
mackup restore, when a destination already exists and replacement is confirmed, Mackup deletes the existing path before copying from backup.If deletion raises
PermissionError(e.g. protected app-managed paths), restore currently crashes with a traceback.Changes
ApplicationProfile.copy_files_from_mackup_folder), catchPermissionErroraround destination deletion.PermissionErrorduring restore replacement.Validation
tests/test_application.py.