Rename to message_bus_client to avoid namespace clash by mikz · Pull Request #6 · lowjoel/message_bus-client

mikz · 2017-08-08T17:23:54Z

Fixes #5 by changing the namespace to MessageBusClient.

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/IndentHash has the wrong namespace - should be Layout
Error: The `Style/TrailingComma` cop no longer exists. Please use `Style/TrailingCommaInLiteral` and/or `Style/TrailingCommaInArguments` instead.
(obsolete configuration found in .rubocop.yml, please update it)
The `Style/DeprecatedHashMethods` cop has been renamed to `Style/PreferredHashMethods`.

houndci-bot

Some files could not be reviewed due to errors:

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout

.rubocop.yml: Style/DotPosition has the wrong namespace - should be Layout
.rubocop.yml: Style/IndentHash has the wrong namespace - should be Layout
Error: The `Style/TrailingComma` cop no longer exists. Please use `Style/TrailingCommaInLiteral` and/or `Style/TrailingCommaInArguments` instead.
(obsolete configuration found in .rubocop.yml, please update it)
The `Style/DeprecatedHashMethods` cop has been renamed to `Style/PreferredHashMethods`.

houndci-bot · 2017-08-09T04:58:18Z

@@ -1,17 +1,17 @@
-RSpec.describe MessageBus::Client do
+RSpec.describe MessageBusClient do


Block has too many lines. [93/25]
Missing magic comment # frozen_string_literal: true.

houndci-bot · 2017-08-09T04:58:18Z

@@ -0,0 +1,3 @@
+class MessageBusClient
+  VERSION = '0.2.0'


Freeze mutable objects assigned to constants.

houndci-bot · 2017-08-09T04:58:18Z

@@ -0,0 +1,3 @@
+class MessageBusClient


Missing magic comment # frozen_string_literal: true.

houndci-bot · 2017-08-09T04:58:19Z

@@ -1,4 +1,4 @@
-module MessageBus::Client::MessageHandler
+module MessageBusClient::MessageHandler


Missing magic comment # frozen_string_literal: true.

houndci-bot · 2017-08-09T04:58:19Z

@@ -1,4 +1,4 @@
-module MessageBus::Client::Connection
+module MessageBusClient::Connection


Missing magic comment # frozen_string_literal: true.

houndci-bot · 2017-08-09T04:58:19Z

@@ -1,4 +1,4 @@
-module MessageBus::Client::Configuration
+module MessageBusClient::Configuration


Missing magic comment # frozen_string_literal: true.

houndci-bot · 2017-08-09T04:58:19Z

@@ -0,0 +1,19 @@
+require 'excon'


Missing magic comment # frozen_string_literal: true.

houndci-bot · 2017-08-09T04:58:19Z

@@ -1,17 +1,17 @@
-RSpec.describe MessageBus::Client do
+RSpec.describe MessageBusClient do


Block has too many lines. [93/25]
Missing magic comment # frozen_string_literal: true.

houndci-bot · 2017-08-09T04:58:19Z

@@ -0,0 +1,3 @@
+class MessageBusClient
+  VERSION = '0.2.0'


Freeze mutable objects assigned to constants.

houndci-bot · 2017-08-09T04:58:19Z

@@ -0,0 +1,3 @@
+class MessageBusClient


Missing magic comment # frozen_string_literal: true.

houndci-bot · 2017-08-09T04:58:19Z

@@ -1,4 +1,4 @@
-module MessageBus::Client::MessageHandler
+module MessageBusClient::MessageHandler


Missing magic comment # frozen_string_literal: true.

houndci-bot · 2017-08-09T04:58:19Z

@@ -1,4 +1,4 @@
-module MessageBus::Client::Connection
+module MessageBusClient::Connection


Missing magic comment # frozen_string_literal: true.

houndci-bot · 2017-08-09T04:58:19Z

@@ -1,4 +1,4 @@
-module MessageBus::Client::Configuration
+module MessageBusClient::Configuration


Missing magic comment # frozen_string_literal: true.

houndci-bot · 2017-08-09T04:58:20Z

@@ -0,0 +1,19 @@
+require 'excon'


Missing magic comment # frozen_string_literal: true.

houndci-bot · 2017-08-09T05:07:59Z

+# frozen_string_literal: true
+
+class MessageBusClient
+  VERSION = '0.2.0'.freeze


Do not freeze immutable objects, as freezing them has no effect.

houndci-bot · 2017-08-09T05:07:59Z


  # The chunk separator for chunked messages.
-  CHUNK_SEPARATOR = "\r\n|\r\n"
+  CHUNK_SEPARATOR = "\r\n|\r\n".freeze


Do not freeze immutable objects, as freezing them has no effect.

houndci-bot · 2017-08-09T05:34:19Z

+
+    example.run
+
+    at_exit {


Avoid using {...} for multi-line blocks.

houndci-bot · 2017-08-09T05:34:19Z

+
+    example.run
+
+    at_exit {


Avoid using {...} for multi-line blocks.

houndci-bot · 2017-08-09T05:38:36Z

+    at_exit do
+      Chat.quit!
+      server.kill
+    do


unexpected token kDO

houndci-bot · 2017-08-09T05:38:36Z

+    at_exit do
+      Chat.quit!
+      server.kill
+    do


unexpected token kDO

houndci-bot · 2017-08-11T12:25:29Z

+require File.join(chat_example_path, 'chat')
+
+RSpec.configure do |config|
+  config.before(:suite) do |example|


Unused block argument - example. You can omit the argument if you don't care about it.

houndci-bot · 2017-08-11T12:25:29Z

-  def stop
-    return unless @state == STARTED || @state == PAUSED
+  def stop(timeout = nil)
+    raise ThreadError if Thread.current == @runner


Use fail instead of raise to signal exceptions.

fixes lowjoel#5

try to gracefully stop or kill the runner thread

that can be result of some interrupted connection like https://travis-ci.org/lowjoel/message_bus-client/jobs/266253959

houndci-bot reviewed Aug 8, 2017

View reviewed changes

houndci-bot reviewed Aug 9, 2017

View reviewed changes

mikz force-pushed the master branch 2 times, most recently from 65bc121 to 706674c Compare August 9, 2017 05:34

houndci-bot reviewed Aug 9, 2017

View reviewed changes

Comment thread spec/chat_server_helper.rb Outdated

example.run

at_exit {

houndci-bot Aug 9, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using {...} for multi-line blocks.

houndci-bot reviewed Aug 9, 2017

View reviewed changes

Comment thread spec/chat_server_helper.rb Outdated

example.run

at_exit {

houndci-bot Aug 9, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using {...} for multi-line blocks.

mikz force-pushed the master branch from 706674c to 9a3e889 Compare August 9, 2017 05:38

houndci-bot reviewed Aug 9, 2017

View reviewed changes

Comment thread spec/chat_server_helper.rb Outdated

at_exit do

Chat.quit!

server.kill

do

houndci-bot Aug 9, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unexpected token kDO

houndci-bot reviewed Aug 9, 2017

View reviewed changes

Comment thread spec/chat_server_helper.rb Outdated

at_exit do

Chat.quit!

server.kill

do

houndci-bot Aug 9, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unexpected token kDO

mikz force-pushed the master branch 2 times, most recently from 3040e62 to fcdd949 Compare August 11, 2017 12:25

houndci-bot reviewed Aug 11, 2017

View reviewed changes

mikz force-pushed the master branch from fcdd949 to 7527d08 Compare August 11, 2017 12:29

mikz added 9 commits August 19, 2017 13:01

[git] ignore .idea folder

94fd9cd

[git] ignore spec/examples.txt

f6614e5

require missing SecureRandom

72ed447

[spec] run the chat server as part of rspec

90fc35c

rename to message_bus_client

cd5b98b

fixes lowjoel#5

[spec] updated coverage helper

fd3a91b

[rubocop] fix rubocop configuration

3974dee

[rubocop] auto-correct

c2aae79

[rubocop] disable block length in rspec

cf8d739

mikz force-pushed the master branch from 7527d08 to 8f15a8d Compare August 19, 2017 11:02

mikz added 4 commits August 19, 2017 14:51

require ruby >= 2.3

827d7c1

[rubocop] frozen strings

1091438

replace integer states with symbols

5ae8069

ability to stop the client with a timeout

c3f31c1

try to gracefully stop or kill the runner thread

mikz force-pushed the master branch from 8f15a8d to 455333f Compare August 19, 2017 12:51

handle empty responses when polling

d2e7f38

that can be result of some interrupted connection like https://travis-ci.org/lowjoel/message_bus-client/jobs/266253959

mikz force-pushed the master branch from 455333f to d2e7f38 Compare August 19, 2017 12:52

		@@ -1,17 +1,17 @@
		RSpec.describe MessageBus::Client do
		RSpec.describe MessageBusClient do

		@@ -1,4 +1,4 @@
		module MessageBus::Client::MessageHandler
		module MessageBusClient::MessageHandler

		@@ -1,4 +1,4 @@
		module MessageBus::Client::Connection
		module MessageBusClient::Connection

		@@ -1,4 +1,4 @@
		module MessageBus::Client::Configuration
		module MessageBusClient::Configuration

Conversation

mikz commented Aug 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

houndci-bot left a comment

Choose a reason for hiding this comment

Uh oh!

houndci-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mikz commented Aug 8, 2017 •

edited

Loading