pin CryptoSwift version to 1.10, update usages of .bytes to .byteArray#76
Open
yurique wants to merge 1 commit into
Open
pin CryptoSwift version to 1.10, update usages of .bytes to .byteArray#76yurique wants to merge 1 commit into
yurique wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: krzyzanowskim/CryptoSwift#1076
CryptoSwiftused to provide the.bytesextension forData.byteswas introduced as part of Foundation, resulting in name-clash and failed compilation.bytesfromCryptoSwiftused to return anArray<UInt8>, but.bytesfrom Foundation returns aRawSpan, so the compilation fails (in newer xcode - because the type is different, in older xcode - because.bytesis not yet available in Foundation)CryptoSwiftthey had no choice but to rename the old.bytesto.byteArraySo the only (as far as I can tell) reliable fix that is compatible with all xcode versions is to pin
CryptoSwiftto the later version (1.10.0) in this project and switch to.byteArrayinstead of.bytes.Edit:
I'm not 100% sure that just having a newer xcode is enough. It might be the case that both a newer version xcode (with built-in
.bytes) AND xcode resolving CryptoSwift to a later version (that no longer has.bytes) is necessary.Edit2:
apparently both conditions are needed indeed: new xcode AND new version of CryptoSwift
(I don't know why/if xcode would resolve to a newer version of CryptoSwift on its own, or if some user input/error is needed)