fix(scroll): revised Scrollable design for better interoperability#2509
Open
cyfung1031 wants to merge 1 commit into
Open
fix(scroll): revised Scrollable design for better interoperability#2509cyfung1031 wants to merge 1 commit into
Scrollable design for better interoperability#2509cyfung1031 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2508
Description
Fix
.overflow_y_scrollbar()/.overflow_scrollbar()layout behavior when used with layout styles such as.gap().Previously,
Scrollablerendered an additional internal scroll-areadivand inserted the caller's element as a child of that wrapper. This changed the layout structure and could cause styles applied to the original element, such as flex gap, to no longer behave as expected.This PR changes
Scrollableso the original element itself becomes the scroll-tracked container. The outer wrapper is only used to preserve sizing and overlay the scrollbar. This keeps the caller's layout styles intact while still rendering the scrollbar.Main changes:
InteractiveElementimplementation forScrollable<E>.Screenshot
How to Test
.overflow_y_scrollbar()with a flex layout and.gap(), for example:.overflow_scrollbar(),.overflow_x_scrollbar(), and.overflow_y_scrollbar()usages still work.Checklist
cargo runfor story tests related to the changes.